Re: [Libvir] Re: PATCH 2/2: Reporting of ACPI/APIC features for HVM Xen

2007-07-30 Thread Daniel Veillard
On Fri, Jul 27, 2007 at 04:24:46PM -0700, David Lutterkort wrote: > Updated patch, incorporating feedback. > > Besides formatting, changes how apic is reported - and that's not > pretty. As danpb found out, in cset 12423:ebed72718263 in xen-unstable, > setting the apic was removed from tools/libxc

Re: [Libvir] Re: PATCH 2/2: Reporting of ACPI/APIC features for HVM Xen

2007-07-27 Thread David Lutterkort
Updated patch, incorporating feedback. Besides formatting, changes how apic is reported - and that's not pretty. As danpb found out, in cset 12423:ebed72718263 in xen-unstable, setting the apic was removed from tools/libxc/xc_hvm_build.c. In a surprising turn of events, cset 12569:9d6bc06919e0 c

[Libvir] Re: PATCH 2/2: Reporting of ACPI/APIC features for HVM Xen

2007-07-27 Thread David Lutterkort
On Tue, 2007-07-24 at 15:42 -0500, Anthony Liguori wrote: > David Lutterkort wrote: > > For HVM Xen, state that ACPI and APIC can be turned on and off. > > I'm pretty sure that in recent versions of Xen, both of these features > are unconditionally enabled. >From testing this a little (after fig

Re: [Libvir] Re: PATCH 2/2: Reporting of ACPI/APIC features for HVM Xen

2007-07-25 Thread Daniel Veillard
On Tue, Jul 24, 2007 at 10:32:34AM -0700, David Lutterkort wrote: > For HVM Xen, state that ACPI and APIC can be turned on and off. Looks fine to me except for the point raised by Anthony and some cleanup: > if (r == -1) goto vir_buffer_failed; > } > +if (guest_ar

[Libvir] Re: PATCH 2/2: Reporting of ACPI/APIC features for HVM Xen

2007-07-24 Thread Anthony Liguori
David Lutterkort wrote: For HVM Xen, state that ACPI and APIC can be turned on and off. I'm pretty sure that in recent versions of Xen, both of these features are unconditionally enabled. Regards, Anthony Liguori David -- Libvir-list mailing list Libvir-list@redhat.com https://www.redh

[Libvir] Re: PATCH 2/2: Reporting of ACPI/APIC features for HVM Xen

2007-07-24 Thread David Lutterkort
For HVM Xen, state that ACPI and APIC can be turned on and off. David Index: libvirt/src/xen_internal.c === --- libvirt.orig/src/xen_internal.c 2007-07-24 09:42:16.0 -0700 +++ libvirt/src/xen_internal.c 2007-07-24 09:43:25.0