Re: [Libvir] avoid more format string warnings

2008-01-16 Thread Jim Meyering
"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> virsh.c:6896: warning: format not a string literal and no format arguments > > Yes, I was getting these too when I was using gcc 4 under Windows. > > +1 to this patch - it looks fine. Thanks. I've committed it. -- Libvir-

Re: [Libvir] avoid more format string warnings

2008-01-16 Thread Richard W.M. Jones
Jim Meyering wrote: virsh.c:6896: warning: format not a string literal and no format arguments Yes, I was getting these too when I was using gcc 4 under Windows. +1 to this patch - it looks fine. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Re

[Libvir] avoid more format string warnings

2008-01-16 Thread Jim Meyering
I compiled libvirt with the latest gcc in rawhide and these CFLAGS: -O -Wall -Wcast-align -Wextra -Wformat -Wformat-security -Winit-self -Winline -Wmissing-prototypes -Wnested-externs -Wno-sign-compare -Wp,-D_FORTIFY_SOURCE=2 -Wpointer-arith -Wredundant-decls -Wshadow