Re: [Libvir] diagnose invalid domain ID numbers (and invalid integers, in general)

2007-11-18 Thread Daniel P. Berrange
On Sat, Nov 17, 2007 at 05:09:51PM -0500, Daniel Veillard wrote: > On Sat, Nov 17, 2007 at 01:17:34PM +, Daniel P. Berrange wrote: > > On Fri, Nov 09, 2007 at 10:30:15PM +0100, Jim Meyering wrote: > > > +TESTS_ENVIRONMENT = \ > > > + abs_top_builddir='$(abs_top_bui

Re: [Libvir] diagnose invalid domain ID numbers (and invalid integers, in general)

2007-11-18 Thread Daniel P. Berrange
On Sat, Nov 17, 2007 at 11:50:56PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > The change I applied was this: > ... > > TESTS_ENVIRONMENT =\ > > - abs_top_builddir='$(abs_top_builddir)' \ > > - abs_top_srcdir='$(abs_top_srcdi

Re: [Libvir] diagnose invalid domain ID numbers (and invalid integers, in general)

2007-11-17 Thread Jim Meyering
Daniel Veillard <[EMAIL PROTECTED]> wrote: > On Sat, Nov 17, 2007 at 01:17:34PM +, Daniel P. Berrange wrote: >> On Fri, Nov 09, 2007 at 10:30:15PM +0100, Jim Meyering wrote: >> > +TESTS_ENVIRONMENT = \ >> > + abs_top_builddir='$(abs_top_builddir)' \ >> > + abs_

Re: [Libvir] diagnose invalid domain ID numbers (and invalid integers, in general)

2007-11-17 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > The change I applied was this: ... > TESTS_ENVIRONMENT = \ > - abs_top_builddir='$(abs_top_builddir)' \ > - abs_top_srcdir='$(abs_top_srcdir)' \ > + abs_top_builddir=`pwd`/$(top_builddir) \ > + abs_top_s

Re: [Libvir] diagnose invalid domain ID numbers (and invalid integers, in general)

2007-11-17 Thread Daniel Veillard
On Sat, Nov 17, 2007 at 01:17:34PM +, Daniel P. Berrange wrote: > On Fri, Nov 09, 2007 at 10:30:15PM +0100, Jim Meyering wrote: > > +TESTS_ENVIRONMENT =\ > > + abs_top_builddir='$(abs_top_builddir)' \ > > + abs_top_srcdir='$(abs_top_srcdir)' \ >

Re: [Libvir] diagnose invalid domain ID numbers (and invalid integers, in general)

2007-11-17 Thread Daniel P. Berrange
On Fri, Nov 09, 2007 at 10:30:15PM +0100, Jim Meyering wrote: > Jim Meyering <[EMAIL PROTECTED]> wrote: > > There are over 30 uses of strtol in libvirt, and they all can silently > > accept invalid input. The invalid string might range from an outlandish > > domain ID like 4294967298 to strings of

Re: [Libvir] diagnose invalid domain ID numbers (and invalid integers, in general)

2007-11-12 Thread Daniel Veillard
On Fri, Nov 09, 2007 at 10:30:15PM +0100, Jim Meyering wrote: > Jim Meyering <[EMAIL PROTECTED]> wrote: > > There are over 30 uses of strtol in libvirt, and they all can silently > > accept invalid input. The invalid string might range from an outlandish > > domain ID like 4294967298 to strings of

Re: [Libvir] diagnose invalid domain ID numbers (and invalid integers, in general)

2007-11-09 Thread Jim Meyering
Jim Meyering <[EMAIL PROTECTED]> wrote: > There are over 30 uses of strtol in libvirt, and they all can silently > accept invalid input. The invalid string might range from an outlandish > domain ID like 4294967298 to strings of digits followed by bogus alpha. > Maybe not worth worrying about, you

[Libvir] diagnose invalid domain ID numbers (and invalid integers, in general)

2007-11-09 Thread Jim Meyering
Hello, There are over 30 uses of strtol in libvirt, and they all can silently accept invalid input. The invalid string might range from an outlandish domain ID like 4294967298 to strings of digits followed by bogus alpha. Maybe not worth worrying about, you say? But what if they indicate user co