Re: [Libvir] gnulib: take2, trunk-relative patch

2007-12-06 Thread Richard W.M. Jones
+1 ... I've been (slowly) adding #include config.h to any files I can find too. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in

[Libvir] gnulib: take2, trunk-relative patch

2007-12-05 Thread Jim Meyering
Here's the complete patch (but still none of the new files), rebased and relative to the trunk. As before, this passes make distcheck. And as Daniel Veillard noted, you'd need git. However the next patch will cvs-add all of the bootstrap-imported files, so you won't need git unless you want to

Re: [Libvir] gnulib: take2, trunk-relative patch

2007-12-05 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: Jim, I also needed the attached patch, and then I had to do this: cd docs/examples ./index.py ... -LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la +LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la

Re: [Libvir] gnulib: take2, trunk-relative patch

2007-12-05 Thread Daniel Veillard
On Wed, Dec 05, 2007 at 05:41:52PM +0100, Jim Meyering wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: I put tests/gnulib before tests there to make it clear that the gnulib tests run before any bit of libvirt's own unit tests. Either way works. We already have many SUBDIRS listed in

Re: [Libvir] gnulib: take2, trunk-relative patch

2007-12-05 Thread Richard W.M. Jones
Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: Jim, I also needed the attached patch, and then I had to do this: cd docs/examples ./index.py ... -LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la +LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS)

Re: [Libvir] gnulib: take2, trunk-relative patch

2007-12-05 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: Jim, I also needed the attached patch, and then I had to do this: cd docs/examples ./index.py ... -LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la +LDADDS

Re: [Libvir] gnulib: take2, trunk-relative patch

2007-12-05 Thread Richard W.M. Jones
Jim, to use the gnulib string.h replacement with GCC 4.1.2 compiled under MinGW, I needed to patch lib/string.h as follows: --- gnulib/lib/string.h~2007-12-05 18:29:29.0 + +++ gnulib/lib/string.h 2007-12-05 19:36:22.0 + @@ -280,7 +280,7 @@ See also

Re: [Libvir] gnulib: take2, trunk-relative patch

2007-12-05 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: On Wed, Dec 05, 2007 at 03:08:11PM +0100, Jim Meyering wrote: Here's the complete patch (but still none of the new files), rebased and relative to the trunk. As before, this passes make distcheck. And as Daniel Veillard noted, you'd need git.

Re: [Libvir] gnulib: take2, trunk-relative patch

2007-12-05 Thread Daniel P. Berrange
On Wed, Dec 05, 2007 at 05:36:48PM +0100, Jim Meyering wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: On Wed, Dec 05, 2007 at 03:08:11PM +0100, Jim Meyering wrote: Here's the complete patch (but still none of the new files), rebased and relative to the trunk. As before, this passes

Re: [Libvir] gnulib: take2, trunk-relative patch

2007-12-05 Thread Richard W.M. Jones
Jim, and this one. This is actually something which I accidentally committed to CVS, but if you agree I think it should be removed. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor,

Re: [Libvir] gnulib: take2, trunk-relative patch

2007-12-05 Thread Daniel P. Berrange
On Wed, Dec 05, 2007 at 03:08:11PM +0100, Jim Meyering wrote: Here's the complete patch (but still none of the new files), rebased and relative to the trunk. As before, this passes make distcheck. And as Daniel Veillard noted, you'd need git. However the next patch will cvs-add all of the

Re: [Libvir] gnulib: take2, trunk-relative patch

2007-12-05 Thread Richard W.M. Jones
Jim Meyering wrote: (1) Need to add ``--avoid=alloca-opt-tests'' to bootstrap. I wonder why I didn't hit that. Did you add any modules to the list in bootstrap? Not yet :-) Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley

Re: [Libvir] gnulib: take2, trunk-relative patch

2007-12-05 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: Jim, I also needed the attached patch, and then I had to do this: cd docs/examples ./index.py ... -LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la +LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la

Re: [Libvir] gnulib: take2, trunk-relative patch

2007-12-05 Thread Richard W.M. Jones
Jim, I also needed the attached patch, and then I had to do this: cd docs/examples ./index.py Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom.

Re: [Libvir] gnulib: take2, trunk-relative patch

2007-12-05 Thread Daniel Veillard
On Wed, Dec 05, 2007 at 09:51:15PM +0100, Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: Jim, to use the gnulib string.h replacement with GCC 4.1.2 compiled under MinGW, I needed to patch lib/string.h as follows: --- gnulib/lib/string.h~2007-12-05

Re: [Libvir] gnulib: take2, trunk-relative patch

2007-12-05 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: Jim, to use the gnulib string.h replacement with GCC 4.1.2 compiled under MinGW, I needed to patch lib/string.h as follows: --- gnulib/lib/string.h~2007-12-05 18:29:29.0 + +++ gnulib/lib/string.h 2007-12-05 19:36:22.0

Re: [Libvir] gnulib: take2, trunk-relative patch

2007-12-05 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: On Wed, Dec 05, 2007 at 03:08:11PM +0100, Jim Meyering wrote: Here's the complete patch (but still none of the new files), rebased and relative to the trunk. As before, this passes make distcheck. And as Daniel Veillard noted, you'd need git.