Re: [Libvir] many more translatable strings need to be marked

2008-03-04 Thread Daniel P. Berrange
On Fri, Feb 29, 2008 at 10:02:35AM -0500, Daniel Veillard wrote: On Fri, Feb 29, 2008 at 03:48:18PM +0100, Jim Meyering wrote: I've found many more strings that should be marked for translation. The first part of this change is to add to the list of diagnostic-printing function names in

Re: [Libvir] many more translatable strings need to be marked

2008-02-29 Thread Jim Meyering
Daniel Veillard [EMAIL PROTECTED] wrote: On Fri, Feb 29, 2008 at 03:48:18PM +0100, Jim Meyering wrote: I've found many more strings that should be marked for translation. The first part of this change is to add to the list of diagnostic-printing function names in Makefile.maint and to make

Re: [Libvir] many more translatable strings need to be marked

2008-02-29 Thread Richard W.M. Jones
On Fri, Feb 29, 2008 at 10:02:35AM -0500, Daniel Veillard wrote: While I undertand the point maybe it's pushed a bit too much, or not enough if (args-maxnames REMOTE_DOMAIN_NAME_LIST_MAX) { remoteDispatchError (client, req, - maxnames

Re: [Libvir] many more translatable strings need to be marked

2008-02-29 Thread Daniel Veillard
On Fri, Feb 29, 2008 at 03:48:18PM +0100, Jim Meyering wrote: I've found many more strings that should be marked for translation. The first part of this change is to add to the list of diagnostic-printing function names in Makefile.maint and to make that list more readable. I marked some

Re: [Libvir] many more translatable strings need to be marked

2008-02-29 Thread Daniel Veillard
On Fri, Feb 29, 2008 at 04:15:47PM +0100, Jim Meyering wrote: Daniel Veillard [EMAIL PROTECTED] wrote: On Fri, Feb 29, 2008 at 03:48:18PM +0100, Jim Meyering wrote: I've found many more strings that should be marked for translation. The first part of this change is to add to the list of

[Libvir] many more translatable strings need to be marked

2008-02-29 Thread Jim Meyering
I've found many more strings that should be marked for translation. The first part of this change is to add to the list of diagnostic-printing function names in Makefile.maint and to make that list more readable. I marked some strings, but am leaving the rest, for now. Running make

Re: [Libvir] many more translatable strings need to be marked

2008-02-29 Thread Jim Meyering
Daniel Veillard [EMAIL PROTECTED] wrote: On Fri, Feb 29, 2008 at 04:15:47PM +0100, Jim Meyering wrote: Daniel Veillard [EMAIL PROTECTED] wrote: On Fri, Feb 29, 2008 at 03:48:18PM +0100, Jim Meyering wrote: I've found many more strings that should be marked for translation. The first part

Re: [Libvir] many more translatable strings need to be marked

2008-02-29 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: ... -remoteDispatchError (client, req, network not found); +remoteDispatchError (client, req, %s, _(network not found)); Though this kind of errors make sense to translate. What doesn't make sense is that the same string (and

Re: [Libvir] many more translatable strings need to be marked

2008-02-29 Thread Jim Meyering
Daniel Veillard [EMAIL PROTECTED] wrote: On Fri, Feb 29, 2008 at 04:54:38PM +0100, Jim Meyering wrote: Daniel Veillard [EMAIL PROTECTED] wrote: But maybe we should consider those as internal errors (which I think they are) and report them as such, the string itself is probably as well

Re: [Libvir] many more translatable strings need to be marked

2008-02-29 Thread Daniel Veillard
On Fri, Feb 29, 2008 at 04:54:38PM +0100, Jim Meyering wrote: Daniel Veillard [EMAIL PROTECTED] wrote: But maybe we should consider those as internal errors (which I think they are) and report them as such, the string itself is probably as well left out of gettext entierely (but the