Re: [Libvir] using gnulib: starting with the physmem and getaddrinfo modules

2007-12-05 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: Richard W.M. Jones wrote: Jim Meyering wrote: -libvirtd_LDADD = ../src/libvirt.la +libvirtd_LDADD = ../src/libvirt.la ../lib/libgnu.la Shouldn't we be using LIBOBJS (automake feature) here? I kind of thought this was how gnulib worked, and it

Re: [Libvir] using gnulib: starting with the physmem and getaddrinfo modules

2007-12-05 Thread Daniel Veillard
On Wed, Dec 05, 2007 at 12:33:24AM +0100, Jim Meyering wrote: Recently, I heard of two tricky portability problems in libvirt that are easy to solve with gnulib. Of course, gnulib provides a lot more, and is not exactly lightweight if you count lines of code imported, but once the framework

Re: [Libvir] using gnulib: starting with the physmem and getaddrinfo modules

2007-12-05 Thread Richard W.M. Jones
Richard W.M. Jones wrote: Jim Meyering wrote: -libvirtd_LDADD = ../src/libvirt.la +libvirtd_LDADD = ../src/libvirt.la ../lib/libgnu.la Shouldn't we be using LIBOBJS (automake feature) here? I kind of thought this was how gnulib worked, and it was what I used for the previous getaddrinfo

Re: [Libvir] using gnulib: starting with the physmem and getaddrinfo modules

2007-12-05 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: ... include physmem.h. For getaddrinfo, merely include getaddrinfo.h from the two files that use the function. Hi Dan, I've not looked closely, but since we're unconditiaonlly including it, I assume the getaddrinfo.h file is setup to not override

Re: [Libvir] using gnulib: starting with the physmem and getaddrinfo modules

2007-12-05 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: More modules we could use (all for MinGW / Windows): ... - gettext MinGW lacks libintl.h and any gettext function. I thought that gettextize was supposed to supply all the code needed to implement these? Anyhow, it doesn't seem to. Hi

Re: [Libvir] using gnulib: starting with the physmem and getaddrinfo modules

2007-12-05 Thread Richard W.M. Jones
Daniel P. Berrange wrote: I think the source code should go into gnulib/*.[ch] in case we ever want to have a lib/ dir for code shared by the daemon library. There's no need to pollute the top level dir with gl-tests, when we can have tests/gnulib/, or gnulib/tests/. We've already got an

[Libvir] using gnulib: starting with the physmem and getaddrinfo modules

2007-12-04 Thread Jim Meyering
Recently, I heard of two tricky portability problems in libvirt that are easy to solve with gnulib. Of course, gnulib provides a lot more, and is not exactly lightweight if you count lines of code imported, but once the framework (this patch) is installed, adding an additional module is as easy

Re: [Libvir] using gnulib: starting with the physmem and getaddrinfo modules

2007-12-04 Thread Daniel P. Berrange
On Wed, Dec 05, 2007 at 12:33:24AM +0100, Jim Meyering wrote: The first portability problem was to determine the total physical memory available on the current system. Currently the code works only on Linux-like systems that have /proc/meminfo of an expected form. However, the gnulib physmem