Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file

2021-05-03 Thread Igor Mammedov
On Wed, 28 Apr 2021 12:29:30 -0400 Eduardo Habkost wrote: > On Tue, Apr 27, 2021 at 04:48:48PM -0400, Eduardo Habkost wrote: > > On Mon, Jan 11, 2021 at 03:33:32PM -0500, Igor Mammedov wrote: > > > It is not safe to pretend that emulated NVDIMM supports > > > persistence while backend actually

Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file

2021-04-28 Thread Eduardo Habkost
On Tue, Apr 27, 2021 at 04:48:48PM -0400, Eduardo Habkost wrote: > On Mon, Jan 11, 2021 at 03:33:32PM -0500, Igor Mammedov wrote: > > It is not safe to pretend that emulated NVDIMM supports > > persistence while backend actually failed to enable it > > and used non-persistent mapping as fall back.

Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file

2021-04-27 Thread Eduardo Habkost
On Mon, Jan 11, 2021 at 03:33:32PM -0500, Igor Mammedov wrote: > It is not safe to pretend that emulated NVDIMM supports > persistence while backend actually failed to enable it > and used non-persistent mapping as fall back. > Instead of falling-back, QEMU should be more strict and > error out

Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file

2021-01-20 Thread Philippe Mathieu-Daudé
Cc'ing MST. On 1/20/21 8:31 PM, Igor Mammedov wrote: > On Mon, 11 Jan 2021 15:33:32 -0500 > Igor Mammedov wrote: > >> It is not safe to pretend that emulated NVDIMM supports >> persistence while backend actually failed to enable it >> and used non-persistent mapping as fall back. >> Instead of

Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file

2021-01-20 Thread Igor Mammedov
On Mon, 11 Jan 2021 15:33:32 -0500 Igor Mammedov wrote: > It is not safe to pretend that emulated NVDIMM supports > persistence while backend actually failed to enable it > and used non-persistent mapping as fall back. > Instead of falling-back, QEMU should be more strict and > error out with

[PATCH] Deprecate pmem=on with non-DAX capable backend file

2021-01-11 Thread Igor Mammedov
It is not safe to pretend that emulated NVDIMM supports persistence while backend actually failed to enable it and used non-persistent mapping as fall back. Instead of falling-back, QEMU should be more strict and error out with clear message that it's not supported. So if user asks for persistence

Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file

2020-12-29 Thread Igor Mammedov
On Tue, 29 Dec 2020 19:04:58 +0100 Philippe Mathieu-Daudé wrote: > On 12/29/20 6:29 PM, Igor Mammedov wrote: > > It is not safe to pretend that emulated NVDIMM supports > > persistence while backend actually failed to enable it > > and used non-persistent mapping as fall back. > > Instead of

Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file

2020-12-29 Thread Philippe Mathieu-Daudé
On 12/29/20 6:29 PM, Igor Mammedov wrote: > It is not safe to pretend that emulated NVDIMM supports > persistence while backend actually failed to enable it > and used non-persistent mapping as fall back. > Instead of falling-back, QEMU should be more strict and > error out with clear message that

[PATCH] Deprecate pmem=on with non-DAX capable backend file

2020-12-29 Thread Igor Mammedov
It is not safe to pretend that emulated NVDIMM supports persistence while backend actually failed to enable it and used non-persistent mapping as fall back. Instead of falling-back, QEMU should be more strict and error out with clear message that it's not supported. So if user asks for persistence