Re: [PATCH] Make virConnectOpenInternal() report error in all cases

2022-01-06 Thread Ani Sinha
On Thu, 6 Jan 2022, Daniel P. Berrangé wrote: > On Thu, Jan 06, 2022 at 08:34:26PM +0530, Ani Sinha wrote: > > virConnectOpenInternal() does not report error in all failure scenarios, > > except > > in some specific cases. > > I don't believe this is correct. My reading of the code is that it >

Re: [PATCH] Make virConnectOpenInternal() report error in all cases

2022-01-06 Thread Daniel P . Berrangé
On Thu, Jan 06, 2022 at 08:34:26PM +0530, Ani Sinha wrote: > virConnectOpenInternal() does not report error in all failure scenarios, > except > in some specific cases. I don't believe this is correct. My reading of the code is that it is already reporting errors in all exit paths that can return

Re: [PATCH] Make virConnectOpenInternal() report error in all cases

2022-01-06 Thread Peter Krempa
On Thu, Jan 06, 2022 at 20:34:26 +0530, Ani Sinha wrote: > virConnectOpenInternal() does not report error in all failure scenarios, > except > in some specific cases. This inconsistent behavior forces the caller of this > function report a generic error for all failure modes which then hides > sp

Re: [PATCH] Make virConnectOpenInternal() report error in all cases

2022-01-06 Thread Michal Prívozník
On 1/6/22 16:04, Ani Sinha wrote: > virConnectOpenInternal() does not report error in all failure scenarios, > except > in some specific cases. This inconsistent behavior forces the caller of this > function report a generic error for all failure modes which then hides > specific > error scenario

[PATCH] Make virConnectOpenInternal() report error in all cases

2022-01-06 Thread Ani Sinha
virConnectOpenInternal() does not report error in all failure scenarios, except in some specific cases. This inconsistent behavior forces the caller of this function report a generic error for all failure modes which then hides specific error scenarios. This change makes virConnectOpenInternal() re