Re: [PATCH] admin: use g_autofree

2020-03-02 Thread Peter Krempa
On Mon, Mar 02, 2020 at 14:13:28 +0530, Gaurav Agrawal wrote: > On review by Jan Tomko, for my earlier Patchv2, which had the return NULL Please don't top-post on technical mailing lists. > replace by the return conn , He told you the correct thing to do: > here is the review: > ``` > >+cleanup

Re: [PATCH] admin: use g_autofree

2020-03-02 Thread Gaurav Agrawal
On review by Jan Tomko, for my earlier Patchv2, which had the return NULL replace by the return conn , here is the review: ``` >+cleanup: > return conn; > > error: > virDispatchError(NULL); >-virObjectUnref(conn); 'conn' is still not marked as g_auto, so this unref needs to stay. >

Re: [PATCH] admin: use g_autofree

2020-03-02 Thread Peter Krempa
On Mon, Mar 02, 2020 at 07:22:03 +0530, Gaurav Agrawal wrote: > Signed-off-by: Gaurav Agrawal > --- > src/admin/libvirt-admin.c | 15 +-- > 1 file changed, 5 insertions(+), 10 deletions(-) [...] > @@ -251,16 +251,11 @@ virAdmConnectOpen(const char *name, unsigned int flags) > i

[PATCH] admin: use g_autofree

2020-03-01 Thread Gaurav Agrawal
Signed-off-by: Gaurav Agrawal --- src/admin/libvirt-admin.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/admin/libvirt-admin.c b/src/admin/libvirt-admin.c index 4099a54854..e272d7a422 100644 --- a/src/admin/libvirt-admin.c +++ b/src/admin/libvirt-admin.

Re: [PATCH] admin: use g_autofree

2020-02-29 Thread Ján Tomko
On a Saturday in 2020, Gaurav Agrawal wrote: From: GAURAV AGRAWAL Your author name is in all caps, consider using the same form as below: Signed-off-by: Gaurav Agrawal To see where it comes from you can use --show-origin: $ git config --show-origin user.name file:/home/jtomko/.gitconfi

[PATCH] admin: use g_autofree

2020-02-29 Thread Gaurav Agrawal
From: GAURAV AGRAWAL Signed-off-by: Gaurav Agrawal --- src/admin/libvirt-admin.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/admin/libvirt-admin.c b/src/admin/libvirt-admin.c index 4099a54854..d841a15f95 100644 --- a/src/admin/libvirt-admin.c +++ b/src/

Re: [PATCH] admin: use g_autofree

2020-02-28 Thread Daniel P . Berrangé
On Fri, Feb 28, 2020 at 11:46:40PM +0530, Gaurav Agrawal wrote: > From: GAURAV AGRAWAL > > Signed-off-by: Gaurav Agrawal > --- > src/admin/libvirt-admin.c | 15 +-- > 1 file changed, 5 insertions(+), 10 deletions(-) > > diff --git a/src/admin/libvirt-admin.c b/src/admin/libvirt-adm

[PATCH] admin: use g_autofree

2020-02-28 Thread Gaurav Agrawal
From: GAURAV AGRAWAL Signed-off-by: Gaurav Agrawal --- src/admin/libvirt-admin.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/admin/libvirt-admin.c b/src/admin/libvirt-admin.c index 4099a54854..17d0eb39fe 100644 --- a/src/admin/libvirt-admin.c +++ b/s