Re: [PATCH] conf: rename virDomainCheckVirtioOptions

2021-01-29 Thread Michal Privoznik
On 1/29/21 1:35 PM, Pavel Hrdina wrote: On Fri, Jan 29, 2021 at 12:39:22PM +0100, Boris Fiuczynski wrote: Rename virDomainCheckVirtioOptions into virDomainCheckVirtioOptionsAreAbent since it checks if all virtio options are absent. The old name was very misleading. Signed-off-by: Boris

Re: [PATCH] conf: rename virDomainCheckVirtioOptions

2021-01-29 Thread Michal Privoznik
On 1/29/21 12:48 PM, Daniel Henrique Barboza wrote: On 1/29/21 8:39 AM, Boris Fiuczynski wrote: Rename virDomainCheckVirtioOptions into virDomainCheckVirtioOptionsAreAbent since it checks if all virtio s/virDomainCheckVirtioOptionsAreAbent/virDomainCheckVirtioOptionsAreAbsent options are

Re: [PATCH] conf: rename virDomainCheckVirtioOptions

2021-01-29 Thread Pavel Hrdina
On Fri, Jan 29, 2021 at 12:39:22PM +0100, Boris Fiuczynski wrote: > Rename virDomainCheckVirtioOptions into > virDomainCheckVirtioOptionsAreAbent since it checks if all virtio > options are absent. The old name was very misleading. > > Signed-off-by: Boris Fiuczynski > --- >

Re: [PATCH] conf: rename virDomainCheckVirtioOptions

2021-01-29 Thread Peter Krempa
On Fri, Jan 29, 2021 at 12:39:22 +0100, Boris Fiuczynski wrote: > Rename virDomainCheckVirtioOptions into > virDomainCheckVirtioOptionsAreAbent since it checks if all virtio > options are absent. The old name was very misleading. We usually have functions which check presence using the 'Has'

Re: [PATCH] conf: rename virDomainCheckVirtioOptions

2021-01-29 Thread Daniel Henrique Barboza
On 1/29/21 8:39 AM, Boris Fiuczynski wrote: Rename virDomainCheckVirtioOptions into virDomainCheckVirtioOptionsAreAbent since it checks if all virtio s/virDomainCheckVirtioOptionsAreAbent/virDomainCheckVirtioOptionsAreAbsent options are absent. The old name was very misleading.

[PATCH] conf: rename virDomainCheckVirtioOptions

2021-01-29 Thread Boris Fiuczynski
Rename virDomainCheckVirtioOptions into virDomainCheckVirtioOptionsAreAbent since it checks if all virtio options are absent. The old name was very misleading. Signed-off-by: Boris Fiuczynski --- src/conf/domain_validate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff