Re: [PATCH] libvirt: ensure defresult is used in virConnectAuthCallbackDefault

2020-09-22 Thread Daniel P . Berrangé
On Mon, Sep 21, 2020 at 10:01:46PM -0400, Matt Coleman wrote: > A previous change to this function's password handling broke the use of > default values for credential types other than VIR_CRED_PASSPHRASE and > VIR_CRED_NOECHOPROMPT. > > Signed-off-by: Matt Coleman > --- > src/libvirt.c | 4

Re: [PATCH] libvirt: ensure defresult is used in virConnectAuthCallbackDefault

2020-09-22 Thread Matt Coleman
Some additional info (feel free to add it to the commit message): Starting in version 6.1.0, virsh does not use the default username while connecting: $ ./run tools/virsh -c hyperv://example-hyperv-server?transport=http capabilities Enter username for example-hyperv-server [administrator]:

[PATCH] libvirt: ensure defresult is used in virConnectAuthCallbackDefault

2020-09-22 Thread Matt Coleman
A previous change to this function's password handling broke the use of default values for credential types other than VIR_CRED_PASSPHRASE and VIR_CRED_NOECHOPROMPT. Signed-off-by: Matt Coleman --- src/libvirt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] libvirt: ensure defresult is used in virConnectAuthCallbackDefault

2020-09-21 Thread Neal Gompa
On Mon, Sep 21, 2020 at 10:02 PM Matt Coleman wrote: > > A previous change to this function's password handling broke the use of > default values for credential types other than VIR_CRED_PASSPHRASE and > VIR_CRED_NOECHOPROMPT. > > Signed-off-by: Matt Coleman > --- > src/libvirt.c | 4 +++- > 1