Re: [PATCH] lxc: fix lxcContainerMountAllFS() DEREF_BEFORE_CHECK

2023-09-07 Thread Martin Kletzander
On Thu, Sep 07, 2023 at 09:25:14AM +0200, Peter Krempa wrote: On Thu, Sep 07, 2023 at 09:11:34 +0200, Martin Kletzander wrote: On Wed, Sep 06, 2023 at 06:34:42PM +0300, Dmitry Frolov wrote: > Reviewing the sources, I found, that > in function lxcContainerMountAllFS() pointers >

Re: [PATCH] lxc: fix lxcContainerMountAllFS() DEREF_BEFORE_CHECK

2023-09-07 Thread Jiri Denemark
On Wed, Sep 06, 2023 at 18:34:42 +0300, Dmitry Frolov wrote: > Reviewing the sources, I found, that > in function lxcContainerMountAllFS() pointers > vmDef->fss[i]->src and vmDef->fss[i]->src->path > are checked for NULL after dereferencing in > VIR_DEBUG() macro. > > Fixes: 57487085dc ("lxc:

Re: [PATCH] lxc: fix lxcContainerMountAllFS() DEREF_BEFORE_CHECK

2023-09-07 Thread Peter Krempa
On Thu, Sep 07, 2023 at 09:11:34 +0200, Martin Kletzander wrote: > On Wed, Sep 06, 2023 at 06:34:42PM +0300, Dmitry Frolov wrote: > > Reviewing the sources, I found, that > > in function lxcContainerMountAllFS() pointers > > vmDef->fss[i]->src and vmDef->fss[i]->src->path > > are checked for NULL

Re: [PATCH] lxc: fix lxcContainerMountAllFS() DEREF_BEFORE_CHECK

2023-09-07 Thread Martin Kletzander
On Wed, Sep 06, 2023 at 06:34:42PM +0300, Dmitry Frolov wrote: Reviewing the sources, I found, that in function lxcContainerMountAllFS() pointers vmDef->fss[i]->src and vmDef->fss[i]->src->path are checked for NULL after dereferencing in VIR_DEBUG() macro. Fixes: 57487085dc ("lxc: don't try to

[PATCH] lxc: fix lxcContainerMountAllFS() DEREF_BEFORE_CHECK

2023-09-06 Thread Dmitry Frolov
Reviewing the sources, I found, that in function lxcContainerMountAllFS() pointers vmDef->fss[i]->src and vmDef->fss[i]->src->path are checked for NULL after dereferencing in VIR_DEBUG() macro. Fixes: 57487085dc ("lxc: don't try to reference NULL when mounting filesystems") ---