Re: [PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-09-10 Thread Cedric Bosdonnat
Hi Ian, On Thu, 2020-09-10 at 09:48 +1000, Ian Wienand wrote: > On Wed, Sep 09, 2020 at 06:38:04AM +, Cedric Bosdonnat wrote: > > The check didn't involve any NetworkManager at all, but a network with > > RA route for the default route. Completely removing the check is rather > > likely to

Re: [PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-09-09 Thread Ian Wienand
On Wed, Sep 09, 2020 at 06:38:04AM +, Cedric Bosdonnat wrote: > The check didn't involve any NetworkManager at all, but a network with > RA route for the default route. Completely removing the check is rather > likely to introduce a regression on that side. Thanks for putting up with my

Re: [PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-09-09 Thread Laine Stump
On 9/9/20 2:38 AM, Cedric Bosdonnat wrote: On Wed, 2020-09-09 at 12:39 +1000, Ian Wienand wrote: On Tue, Sep 01, 2020 at 08:27:47AM +, Cedric Bosdonnat wrote: So the hypervisor has at least one (Router Advertised) RA route. After defining a network like the following, the RA route is

Re: [PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-09-09 Thread Cedric Bosdonnat
On Wed, 2020-09-09 at 12:39 +1000, Ian Wienand wrote: > On Tue, Sep 01, 2020 at 08:27:47AM +, Cedric Bosdonnat wrote: > > So the hypervisor has at least one (Router Advertised) RA route. > > After defining a network like the following, the RA route is removed if > > accept_ra isn't set to 2. >

Re: [PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-09-08 Thread Ian Wienand
On Tue, Sep 01, 2020 at 08:27:47AM +, Cedric Bosdonnat wrote: > So the hypervisor has at least one (Router Advertised) RA route. > After defining a network like the following, the RA route is removed if > accept_ra isn't set to 2. > > > test5 > > > > family="ipv6" >

Re: [PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-09-01 Thread Cedric Bosdonnat
On Wed, 2020-08-12 at 19:21 -0400, Laine Stump wrote: > Yay! A user who follows up their conversation on the libvirt-users list > with a patch! :-) > > On 8/11/20 8:14 PM, Ian Wienand wrote: > > The checks modified here were added with > > 00d28a78b5d1f6eaf79f06ac59e31c568af9da37 to avoid losing

Re: [PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-08-12 Thread Ian Wienand
On Wed, Aug 12, 2020 at 07:21:14PM -0400, Laine Stump wrote: > Yay! A user who follows up their conversation on the libvirt-users list with > a patch! :-) Heh, ipv6 in my work VM is my white whale, so, call me Ishmael :) > Unfortunately, on my Fedora 32 machine that has NetworkManager enabled,

Re: [PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-08-12 Thread Laine Stump
Yay! A user who follows up their conversation on the libvirt-users list with a patch! :-) On 8/11/20 8:14 PM, Ian Wienand wrote: The checks modified here were added with 00d28a78b5d1f6eaf79f06ac59e31c568af9da37 to avoid losing routes on hosts. I'm Cc'ing the author of that patch, Cédric

[PATCH] network: allow accept_ra == 0 when enabling ipv6 forwarding

2020-08-11 Thread Ian Wienand
The checks modified here were added with 00d28a78b5d1f6eaf79f06ac59e31c568af9da37 to avoid losing routes on hosts. However, tools such as systemd-networking and NetworkManager manage RA's in userspace and thus IPv6 may be up and working on an interface even with accept_ra == 0. This modifies the