Re: [PATCH] network: bridge_driver: Use new helpers for storing libvirt errors

On 2/25/20 1:10 PM, Gaurav Agrawal wrote: Hi Laine, I am sure that I did --subject-prefix , not sure why it did not landed. Now am wondering about this situation do I still need a PATCH-3 or it's handled ? Nah, Jano pointed out what I thought of late last night - this is different from the

Re: [PATCH] network: bridge_driver: Use new helpers for storing libvirt errors

Hi Laine, I am sure that I did --subject-prefix , not sure why it did not landed. Now am wondering about this situation do I still need a PATCH-3 or it's handled ? Thanks for giving your one last pass! Best Regards Gaurav On Tue, Feb 25, 2020, 22:46 Laine Stump wrote: > On 2/25/20 7:37 AM,

Re: [PATCH] network: bridge_driver: Use new helpers for storing libvirt errors

On 2/25/20 7:37 AM, Ján Tomko wrote: On Mon, Feb 24, 2020 at 10:09:05PM -0500, Laine Stump wrote: On 2/24/20 1:58 PM, Gaurav Agrawal wrote: Yes, networkSetupPrivateChains is only called once (via virOnce, as suggested by the comment on the top of the function) on initialization and if either

Re: [PATCH] network: bridge_driver: Use new helpers for storing libvirt errors

On Mon, Feb 24, 2020 at 10:09:05PM -0500, Laine Stump wrote: On 2/24/20 1:58 PM, Gaurav Agrawal wrote: From: GAURAV AGRAWAL Signed-off-by: Gaurav Agrawal --- src/network/bridge_driver_linux.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Yay! It applied properly, so you have

[PATCH] network: bridge_driver: Use new helpers for storing libvirt errors

From: GAURAV AGRAWAL Signed-off-by: Gaurav Agrawal --- src/network/bridge_driver_linux.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_linux.c index 7bbde5c6a9..ac92d884b9 100644 ---

Re: [PATCH] network: bridge_driver: Use new helpers for storing libvirt errors

On 2/24/20 1:58 PM, Gaurav Agrawal wrote: From: GAURAV AGRAWAL Signed-off-by: Gaurav Agrawal --- src/network/bridge_driver_linux.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Yay! It applied properly, so you have all the pieces of patch submission properly in line! :-)

[PATCH] network: bridge_driver: Use new helpers for storing libvirt errors

From: GAURAV AGRAWAL Signed-off-by: Gaurav Agrawal --- src/network/bridge_driver_linux.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_linux.c index 7bbde5c6a9..fde33b5d38 100644 ---