Re: [PATCH] node_device: pacify grumpy coverity due to addr override

2020-12-14 Thread Michal Privoznik
On 12/14/20 12:02 PM, Boris Fiuczynski wrote: Michal, since I do not have commit rights I am fine with you doing it. Thanks. Terribly sorry, for some reason I thought you have commit access. Fixed and pushed. Michal

Re: [PATCH] node_device: pacify grumpy coverity due to addr override

2020-12-14 Thread Boris Fiuczynski
On 12/11/20 3:55 PM, Michal Privoznik wrote: On 12/11/20 3:46 PM, Boris Fiuczynski wrote: On 12/11/20 3:33 PM, Michal Privoznik wrote: On 12/10/20 6:32 PM, Boris Fiuczynski wrote: With commit 09364608b4 node_device: refactor address retrieval of node device "if-else if" was replaced by "switc

Re: [PATCH] node_device: pacify grumpy coverity due to addr override

2020-12-11 Thread Michal Privoznik
On 12/11/20 3:46 PM, Boris Fiuczynski wrote: On 12/11/20 3:33 PM, Michal Privoznik wrote: On 12/10/20 6:32 PM, Boris Fiuczynski wrote: With commit 09364608b4 node_device: refactor address retrieval of node device "if-else if" was replaced by "switch". The contained break statement now is no lo

Re: [PATCH] node_device: pacify grumpy coverity due to addr override

2020-12-11 Thread Boris Fiuczynski
On 12/11/20 3:33 PM, Michal Privoznik wrote: On 12/10/20 6:32 PM, Boris Fiuczynski wrote: With commit 09364608b4 node_device: refactor address retrieval of node device "if-else if" was replaced by "switch". The contained break statement now is no longer in context of the for loop but instead of

Re: [PATCH] node_device: pacify grumpy coverity due to addr override

2020-12-11 Thread Michal Privoznik
On 12/10/20 6:32 PM, Boris Fiuczynski wrote: With commit 09364608b4 node_device: refactor address retrieval of node device "if-else if" was replaced by "switch". The contained break statement now is no longer in context of the for loop but instead of the switch causing the legitimate grumpiness o

[PATCH] node_device: pacify grumpy coverity due to addr override

2020-12-10 Thread Boris Fiuczynski
With commit 09364608b4 node_device: refactor address retrieval of node device "if-else if" was replaced by "switch". The contained break statement now is no longer in context of the for loop but instead of the switch causing the legitimate grumpiness of coverity. Signed-off-by: Boris Fiuczynski S