Re: [PATCH] qemu: fix missing cleanup on error in qemuSaveImageStartVM

2021-12-16 Thread Jiri Denemark
On Wed, Dec 15, 2021 at 16:14:34 +0100, Jiri Denemark wrote: > On Wed, Dec 15, 2021 at 18:37:21 +0530, Ani Sinha wrote: > > Commit 52521de8332c2323bd ("qemu: Use qemuDomainSaveStatus") replaced a call > > to virDomainObjSave() with qemuDomainSaveStatus() as a part of cleanup. > > Since > >

Re: [PATCH] qemu: fix missing cleanup on error in qemuSaveImageStartVM

2021-12-15 Thread Jiri Denemark
On Wed, Dec 15, 2021 at 18:37:21 +0530, Ani Sinha wrote: > Commit 52521de8332c2323bd ("qemu: Use qemuDomainSaveStatus") replaced a call > to virDomainObjSave() with qemuDomainSaveStatus() as a part of cleanup. Since > qemuDomainSaveStatus() does not indicate any failure through its return code, >

[PATCH] qemu: fix missing cleanup on error in qemuSaveImageStartVM

2021-12-15 Thread Ani Sinha
Commit 52521de8332c2323bd ("qemu: Use qemuDomainSaveStatus") replaced a call to virDomainObjSave() with qemuDomainSaveStatus() as a part of cleanup. Since qemuDomainSaveStatus() does not indicate any failure through its return code, the error handling cleanup code got eliminated in the process.