Re: [PATCH] qemu_domain: Deduplicate targetNode check in qemuDomainDefValidateMemoryHotplugDevice()

2023-07-13 Thread Kristina Hanicova
On Thu, Jul 13, 2023 at 4:05 PM Michal Privoznik wrote: > If a domain has NUMA configured, then all devices > (except for 'virtio-pmem') need to have targetNode set. There are > two checks inside of qemuDomainDefValidateMemoryHotplugDevice() > for this: one inside of big switch() statement,

[PATCH] qemu_domain: Deduplicate targetNode check in qemuDomainDefValidateMemoryHotplugDevice()

2023-07-13 Thread Michal Privoznik
If a domain has NUMA configured, then all devices (except for 'virtio-pmem') need to have targetNode set. There are two checks inside of qemuDomainDefValidateMemoryHotplugDevice() for this: one inside of big switch() statement, which only checks 'dimm' and 'nvdimm' cases, and the other at the end