Re: [PATCH] tests: switch away from HAVE_SOCKETPAIR

2020-03-19 Thread Daniel P . Berrangé
On Thu, Mar 19, 2020 at 12:05:17PM +0100, Pino Toscano wrote: > Since the removal of gnulib, HAVE_SOCKETPAIR is no more defined, making > these two tests effectively skipped. Doh, I had compared the config.h file before & after gnulib removal to identify HAVE_* macros that no longer existed, but

[PATCH] tests: switch away from HAVE_SOCKETPAIR

2020-03-19 Thread Pino Toscano
Since the removal of gnulib, HAVE_SOCKETPAIR is no more defined, making these two tests effectively skipped. Use the same strategy used in other generic library bits, i.e. exclude the socketpair usage on Windows. Semi-related change in virnetdaemontest.c to make it build: since virutil.h does