Re: [PATCH] util: Rework virFileFlock() to be unambiguous

2020-07-10 Thread Martin Kletzander
On Fri, Jul 10, 2020 at 03:50:07PM +0200, Andrea Bolognani wrote: On Fri, 2020-07-10 at 15:20 +0200, Martin Kletzander wrote: The boolean parameters for lock/unlock and read/write (shared/exclusive) caused a lot of confusion when reading the callers. The new approach is explicit and

Re: [PATCH] util: Rework virFileFlock() to be unambiguous

2020-07-10 Thread Andrea Bolognani
On Fri, 2020-07-10 at 15:20 +0200, Martin Kletzander wrote: > The boolean parameters for lock/unlock and read/write (shared/exclusive) > caused > a lot of confusion when reading the callers. The new approach is explicit and > unambiguous. > > While at it, also change the only caller so that it

[PATCH] util: Rework virFileFlock() to be unambiguous

2020-07-10 Thread Martin Kletzander
The boolean parameters for lock/unlock and read/write (shared/exclusive) caused a lot of confusion when reading the callers. The new approach is explicit and unambiguous. While at it, also change the only caller so that it acquires an exclusive lock as it should've been all the time. This was