Re: [PATCH] util: don't validate empty params

2023-06-26 Thread Kristina Hanicova
On Fri, Jun 23, 2023 at 11:22 AM Oleg Vasilev wrote: > If there are no parameters, there is nothing to validate. > If params == NULL, memcpy below results in memcpy(sorted, NULL, 0), > which is UB. > > Found by UBSAN. Example of this codepath: virDomainBlockCopy() > (where nparams == 0 is valid)

[PATCH] util: don't validate empty params

2023-06-23 Thread Oleg Vasilev
If there are no parameters, there is nothing to validate. If params == NULL, memcpy below results in memcpy(sorted, NULL, 0), which is UB. Found by UBSAN. Example of this codepath: virDomainBlockCopy() (where nparams == 0 is valid) -> qemuDomainBlockCopy() Signed-off-by: Oleg Vasilev --- src/ut