Re: [PATCH] util: xml: remove unused function virXMLChildElementCount

2020-11-06 Thread Ján Tomko
On a Friday in 2020, Yi Li wrote: On 11/6/20, Ján Tomko wrote: On a Friday in 2020, Yi Li wrote: --- src/libvirt_private.syms | 1 - src/util/virxml.c| 21 - src/util/virxml.h| 1 - 3 files changed, 23 deletions(-) Looks good, but it's missing a sign-off.

Re: [PATCH] util: xml: remove unused function virXMLChildElementCount

2020-11-06 Thread Yi Li
On 11/6/20, Ján Tomko wrote: > On a Friday in 2020, Yi Li wrote: >>--- >> src/libvirt_private.syms | 1 - >> src/util/virxml.c| 21 - >> src/util/virxml.h| 1 - >> 3 files changed, 23 deletions(-) >> > > Looks good, but it's missing a sign-off. > > Can you, pleas

Re: [PATCH] util: xml: remove unused function virXMLChildElementCount

2020-11-06 Thread Ján Tomko
On a Friday in 2020, Yi Li wrote: --- src/libvirt_private.syms | 1 - src/util/virxml.c| 21 - src/util/virxml.h| 1 - 3 files changed, 23 deletions(-) Looks good, but it's missing a sign-off. Can you, please, include a Signed-off-by line to indicate you com

[PATCH] util: xml: remove unused function virXMLChildElementCount

2020-11-05 Thread Yi Li
--- src/libvirt_private.syms | 1 - src/util/virxml.c| 21 - src/util/virxml.h| 1 - 3 files changed, 23 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 9029ea4fa2..36ab84162c 100644 --- a/src/libvirt_private.syms +++ b/src