On Fri, 7 Jan 2022, Michal Prívozník wrote:
> On 1/7/22 13:38, Ani Sinha wrote:
> >
>
> >
> > Ok fine but still, life is not ideal ... libraries do have bugs.
>
> In that case, where do we draw the line? Say pthread has a bug and it
> doesn't spawn threads. Worse, it doesn't even return any erro
On 1/7/22 13:38, Ani Sinha wrote:
>
>
> Ok fine but still, life is not ideal ... libraries do have bugs.
In that case, where do we draw the line? Say pthread has a bug and it
doesn't spawn threads. Worse, it doesn't even return any error value.
Should we mitigate that too?
I'd say stick with w
On Fri, 7 Jan 2022, Daniel P. Berrangé wrote:
> On Fri, Jan 07, 2022 at 06:04:04PM +0530, Ani Sinha wrote:
> >
> >
> > On Fri, 7 Jan 2022, Daniel P. Berrangé wrote:
> >
> > > On Fri, Jan 07, 2022 at 05:24:18PM +0530, Ani Sinha wrote:
> > > >
> > > >
> > > > On Fri, 7 Jan 2022, Ján Tomko wrote:
>
On Fri, Jan 07, 2022 at 06:04:04PM +0530, Ani Sinha wrote:
>
>
> On Fri, 7 Jan 2022, Daniel P. Berrangé wrote:
>
> > On Fri, Jan 07, 2022 at 05:24:18PM +0530, Ani Sinha wrote:
> > >
> > >
> > > On Fri, 7 Jan 2022, Ján Tomko wrote:
> > >
> > > > On a Friday in 2022, Ani Sinha wrote:
> > > > > On
On Fri, 7 Jan 2022, Daniel P. Berrangé wrote:
> On Fri, Jan 07, 2022 at 05:24:18PM +0530, Ani Sinha wrote:
> >
> >
> > On Fri, 7 Jan 2022, Ján Tomko wrote:
> >
> > > On a Friday in 2022, Ani Sinha wrote:
> > > > On Fri, 7 Jan 2022, Michal Prívozník wrote:
> > > > > I don't think so. Just like we
On 1/7/22 09:34, Ani Sinha wrote:
>
>
> On Fri, 7 Jan 2022, Michal Prívozník wrote:
>
>> On 1/7/22 09:05, Ani Sinha wrote:
>>>
>>>
>>> On Fri, 7 Jan 2022, Michal Privoznik wrote:
>>>
Both virProcessGetStatInfo() and virProcessGetSchedInfo() are
Linux centric. Provide stubs for non-Linu
On Fri, 7 Jan 2022, Ján Tomko wrote:
> On a Friday in 2022, Ani Sinha wrote:
> >
> >
> > On Fri, 7 Jan 2022, Ján Tomko wrote:
> >
> > > On a Friday in 2022, Ani Sinha wrote:
> > > > On Fri, 7 Jan 2022, Michal Prívozník wrote:
> > > > > I don't think so. Just like we've discussed under one patch
On a Friday in 2022, Ani Sinha wrote:
On Fri, 7 Jan 2022, Ján Tomko wrote:
On a Friday in 2022, Ani Sinha wrote:
> On Fri, 7 Jan 2022, Michal Prívozník wrote:
> > I don't think so. Just like we've discussed under one patch of yours, a
> > function should either report error in all cases or no
On Fri, Jan 07, 2022 at 05:24:18PM +0530, Ani Sinha wrote:
>
>
> On Fri, 7 Jan 2022, Ján Tomko wrote:
>
> > On a Friday in 2022, Ani Sinha wrote:
> > > On Fri, 7 Jan 2022, Michal Prívozník wrote:
> > > > I don't think so. Just like we've discussed under one patch of yours, a
> > > > function sho
On Fri, 7 Jan 2022, Ján Tomko wrote:
> On a Friday in 2022, Ani Sinha wrote:
> > On Fri, 7 Jan 2022, Michal Prívozník wrote:
> > > I don't think so. Just like we've discussed under one patch of yours, a
> > > function should either report error in all cases or none. And in case of
> > > virProce
On a Friday in 2022, Ani Sinha wrote:
On Fri, 7 Jan 2022, Michal Prívozník wrote:
I don't think so. Just like we've discussed under one patch of yours, a
function should either report error in all cases or none. And in case of
virProcessGetSchedInfo() the linux version does report error
I see
On a Friday in 2022, Michal Privoznik wrote:
Both virProcessGetStatInfo() and virProcessGetSchedInfo() are
Linux centric. Provide stubs for non-Linux platforms.
Signed-off-by: Michal Privoznik
---
src/util/virprocess.c | 24
1 file changed, 24 insertions(+)
Reviewed-b
On Fri, Jan 07, 2022 at 08:55:16 +0100, Michal Privoznik wrote:
> Both virProcessGetStatInfo() and virProcessGetSchedInfo() are
> Linux centric. Provide stubs for non-Linux platforms.
Fixes: d73852c49962fbfe652fc7bec595a3f242faf847
>
> Signed-off-by: Michal Privoznik
> ---
> src/util/virproces
On Fri, 7 Jan 2022, Michal Prívozník wrote:
> On 1/7/22 09:05, Ani Sinha wrote:
> >
> >
> > On Fri, 7 Jan 2022, Michal Privoznik wrote:
> >
> >> Both virProcessGetStatInfo() and virProcessGetSchedInfo() are
> >> Linux centric. Provide stubs for non-Linux platforms.
> >>
> >> Signed-off-by: Micha
On 1/7/22 09:05, Ani Sinha wrote:
>
>
> On Fri, 7 Jan 2022, Michal Privoznik wrote:
>
>> Both virProcessGetStatInfo() and virProcessGetSchedInfo() are
>> Linux centric. Provide stubs for non-Linux platforms.
>>
>> Signed-off-by: Michal Privoznik
>> ---
>> src/util/virprocess.c | 24 +++
On Fri, 7 Jan 2022, Michal Privoznik wrote:
> Both virProcessGetStatInfo() and virProcessGetSchedInfo() are
> Linux centric. Provide stubs for non-Linux platforms.
>
> Signed-off-by: Michal Privoznik
> ---
> src/util/virprocess.c | 24
> 1 file changed, 24 insertions(
Both virProcessGetStatInfo() and virProcessGetSchedInfo() are
Linux centric. Provide stubs for non-Linux platforms.
Signed-off-by: Michal Privoznik
---
src/util/virprocess.c | 24
1 file changed, 24 insertions(+)
diff --git a/src/util/virprocess.c b/src/util/virprocess.
17 matches
Mail list logo