[PATCH] virresctrl: Fix updating the mask for a cache resource

2021-07-02 Thread Vinayak Kale
In 'virResctrlAllocUpdateMask', mask is updated only if 'previous mask' is NULL. By default, the bitmask for a cache resource for a VM is initialized with 'default-resctrl-group' bitmask. So the 'previous mask' would not be NULL and mask won't get updated if cachetune is configured for a VM. This

Re: [PATCH] virresctrl: Fix updating the mask for a cache resource

2021-07-07 Thread Jano Tomko
On a %A in %Y, Vinayak Kale wrote: > In 'virResctrlAllocUpdateMask', mask is updated only if 'previous mask' is > NULL. > > By default, the bitmask for a cache resource for a VM is initialized with > 'default-resctrl-group' bitmask. So the 'previous mask' would not be NULL and > mask won't get up

Re: [PATCH] virresctrl: Fix updating the mask for a cache resource

2021-07-07 Thread Daniel Henrique Barboza
On 7/2/21 4:23 AM, Vinayak Kale wrote: In 'virResctrlAllocUpdateMask', mask is updated only if 'previous mask' is NULL. By default, the bitmask for a cache resource for a VM is initialized with 'default-resctrl-group' bitmask. So the 'previous mask' would not be NULL and mask won't get update

Re: [PATCH] virresctrl: Fix updating the mask for a cache resource

2021-07-07 Thread Vinayak Kale
On 07-Jul-21 6:46 PM, Jano Tomko wrote: Signed-off-by: Vinayak Kale --- src/util/virresctrl.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Ján Tomko I will push it after the pipeline passes: https://gitlab.com/janotomko/libvirt/-/pipelines/333213773 Jano T