Re: [PATCH] virsh: Check whether enough arguments was passed to iothreadset

2022-06-08 Thread Claudio Fontana
Reviewed-by: Claudio Fontana On 6/8/22 15:25, Michal Privoznik wrote: > Virsh has iothreadset command which allows setting various > attributes of IOThreads. However, when the command is called > without any arguments (besides domain and IOThread IDs), then > @params stays NULL and is passed to v

Re: [PATCH] virsh: Check whether enough arguments was passed to iothreadset

2022-06-08 Thread Peter Krempa
On Wed, Jun 08, 2022 at 15:25:13 +0200, Michal Privoznik wrote: > Virsh has iothreadset command which allows setting various > attributes of IOThreads. However, when the command is called > without any arguments (besides domain and IOThread IDs), then > @params stays NULL and is passed to virDomain

Re: [PATCH] virsh: Check whether enough arguments was passed to iothreadset

2022-06-08 Thread Michal Prívozník
On 6/8/22 15:27, Peter Krempa wrote: > On Wed, Jun 08, 2022 at 15:25:13 +0200, Michal Privoznik wrote: >> Virsh has iothreadset command which allows setting various >> attributes of IOThreads. However, when the command is called >> without any arguments (besides domain and IOThread IDs), then >> @p

[PATCH] virsh: Check whether enough arguments was passed to iothreadset

2022-06-08 Thread Michal Privoznik
Virsh has iothreadset command which allows setting various attributes of IOThreads. However, when the command is called without any arguments (besides domain and IOThread IDs), then @params stays NULL and is passed to virDomainSetIOThreadParams() which produces rather user unfriendly error message: