[PATCH] virsysinfo: Parse OEM strings

2020-06-02 Thread Michal Privoznik
Setting OEM strings for a domain was introduced in v4.1.0-rc1~315. However, any application that wanted to use them (e.g. to point to an URL where a config file is stored) had to 'dmidecode -u --oem-string N' (where N is index of the string). Well, we can expose them under our XML and if the domai

Re: [PATCH] virsysinfo: Parse OEM strings

2020-06-02 Thread Daniel P . Berrangé
On Tue, Jun 02, 2020 at 12:53:18PM +0200, Michal Privoznik wrote: > Setting OEM strings for a domain was introduced in > v4.1.0-rc1~315. However, any application that wanted to use them > (e.g. to point to an URL where a config file is stored) had to > 'dmidecode -u --oem-string N' (where N is inde

Re: [PATCH] virsysinfo: Parse OEM strings

2020-06-02 Thread Michal Privoznik
On 6/2/20 12:56 PM, Daniel P. Berrangé wrote: On Tue, Jun 02, 2020 at 12:53:18PM +0200, Michal Privoznik wrote: Setting OEM strings for a domain was introduced in v4.1.0-rc1~315. However, any application that wanted to use them (e.g. to point to an URL where a config file is stored) had to 'dmid

Re: [PATCH] virsysinfo: Parse OEM strings

2020-06-03 Thread Daniel P . Berrangé
On Tue, Jun 02, 2020 at 03:11:25PM +0200, Michal Privoznik wrote: > On 6/2/20 12:56 PM, Daniel P. Berrangé wrote: > > On Tue, Jun 02, 2020 at 12:53:18PM +0200, Michal Privoznik wrote: > > > Setting OEM strings for a domain was introduced in > > > v4.1.0-rc1~315. However, any application that wanted

Re: [PATCH] virsysinfo: Parse OEM strings

2020-06-03 Thread Michal Privoznik
On 6/3/20 1:22 PM, Daniel P. Berrangé wrote: With the normal format, we can reliably extract each string, but some chars might have been mangled. How about we keep your current code, but if we see a "." in a string, then we run "dmidecode -u --oem-string N" just for that particular string, in ord