Re: [PATCH 0/7] Sanitize logic to get live/config device definitions for unplug/update

2022-12-05 Thread Ján Tomko
On a Wednesday in 2022, Peter Krempa wrote: Convert code *DomainUpdateDeviceFlags/*DomainDetachDeviceLiveAndConfig to avoid use of virDomainDeviceDefCopy. We have the original XML string from the user so it doesn't make sense to parse it and then copy it (whcih involves formatting and parsing bac

[PATCH 0/7] Sanitize logic to get live/config device definitions for unplug/update

2022-11-23 Thread Peter Krempa
Convert code *DomainUpdateDeviceFlags/*DomainDetachDeviceLiveAndConfig to avoid use of virDomainDeviceDefCopy. We have the original XML string from the user so it doesn't make sense to parse it and then copy it (whcih involves formatting and parsing back), when we can simply parse it twice, saving