Re: [PATCH 0/9] Allow sparse streams for block devices

2020-07-04 Thread Andrea Bolognani
On Fri, 2020-07-03 at 16:06 +0200, Michal Privoznik wrote: > On 7/3/20 3:59 PM, Andrea Bolognani wrote: > > Is this change something that we should mention in the release notes? > > If so, please post a patch that updates them accordingly. Thanks! > > Of course! I was think that I have to write a

Re: [PATCH 0/9] Allow sparse streams for block devices

2020-07-03 Thread Michal Privoznik
On 7/3/20 3:59 PM, Andrea Bolognani wrote: On Fri, 2020-07-03 at 12:28 +0200, Michal Privoznik wrote: Michal Prívozník (9): libvirt-storage: Document volume upload/download stream format virstring: Introduce virStringIsNull() virfile: Introduce virFileInDataDetectZeroes() virsh: Pass

Re: [PATCH 0/9] Allow sparse streams for block devices

2020-07-03 Thread Andrea Bolognani
On Fri, 2020-07-03 at 12:28 +0200, Michal Privoznik wrote: > Michal Prívozník (9): > libvirt-storage: Document volume upload/download stream format > virstring: Introduce virStringIsNull() > virfile: Introduce virFileInDataDetectZeroes() > virsh: Pass virshStreamCallbackDataPtr to virshStre

Re: [PATCH 0/9] Allow sparse streams for block devices

2020-07-03 Thread Daniel P . Berrangé
On Fri, Jul 03, 2020 at 01:50:22PM +0200, Michal Privoznik wrote: > On 7/3/20 1:34 PM, Daniel P. Berrangé wrote: > > On Fri, Jul 03, 2020 at 12:28:41PM +0200, Michal Privoznik wrote: > > > The way our sparse streams are implemented is: > > > > > > 1) user facing APIs (virStreamSparseRecvAll() and

Re: [PATCH 0/9] Allow sparse streams for block devices

2020-07-03 Thread Michal Privoznik
On 7/3/20 1:34 PM, Daniel P. Berrangé wrote: On Fri, Jul 03, 2020 at 12:28:41PM +0200, Michal Privoznik wrote: The way our sparse streams are implemented is: 1) user facing APIs (virStreamSparseRecvAll() and virStreamSparseSendAll()) take callbacks as arguments. These callbacks read/write d

Re: [PATCH 0/9] Allow sparse streams for block devices

2020-07-03 Thread Daniel P . Berrangé
On Fri, Jul 03, 2020 at 12:28:41PM +0200, Michal Privoznik wrote: > The way our sparse streams are implemented is: > > 1) user facing APIs (virStreamSparseRecvAll() and virStreamSparseSendAll()) > take >callbacks as arguments. These callbacks read/write data or determine if > there >is a

[PATCH 0/9] Allow sparse streams for block devices

2020-07-03 Thread Michal Privoznik
The way our sparse streams are implemented is: 1) user facing APIs (virStreamSparseRecvAll() and virStreamSparseSendAll()) take callbacks as arguments. These callbacks read/write data or determine if there is a hole in the underlying file and big it is. 2) libvirtd has something similar - v