Re: [PATCH 01/16] Fix build errors on FreeBSD

2020-02-23 Thread Ryan Moeller
> I'm confused as to why that error can be fixed by removing an include. > If I recall correctly, we used to get that kind of error when using > gnulib's includes but not linking with gnulib. > > Was that on a clean build from a fresh checkout, or do you have some > leftover gnulib artefacts presen

Re: [PATCH 01/16] Fix build errors on FreeBSD

2020-02-23 Thread Ján Tomko
On Sat, Feb 22, 2020 at 01:38:40AM -0500, Ryan Moeller wrote: Don't free the file string until after it has been used to print the error message. These are two independent issues that should be in two separate commits. Also, is the premature free really a build time error? I was seeing `unde

[PATCH 01/16] Fix build errors on FreeBSD

2020-02-21 Thread Ryan Moeller
Don't free the file string until after it has been used to print the error message. I was seeing `undefined symbol: rpl_ioctl` so followed the example set by 05a38d4c4ac035ca5dac0f00ce641a8f9b087831 Signed-off-by: Ryan Moeller --- src/bhyve/bhyve_process.c | 1 - src/conf/virnetworkobj.c | 5 +