Re: [PATCH 01/16] util: virstring: Always copy string in virStrcpy

2021-03-04 Thread Ján Tomko
On a Tuesday in 2021, Peter Krempa wrote: 15 out of 72 invocations of virStrcpy(Static) That's almost 21% ignore the return value as it's either impossible to fail or in certain cases a truncated copy is still good enough.Unfortunately virStrcpy doesn't copy anything in such case as the

[PATCH 01/16] util: virstring: Always copy string in virStrcpy

2021-03-02 Thread Peter Krempa
15 out of 72 invocations of virStrcpy(Static) ignore the return value as it's either impossible to fail or in certain cases a truncated copy is still good enough. Unfortunately virStrcpy doesn't copy anything in such case as the checks are done first. Fix this by using g_strlcpy for the