A couple minor notes below
On Fri, 2020-04-03 at 17:15 +0200, Rafael Fonseca wrote:
> Signed-off-by: Rafael Fonseca
> ---
> src/conf/capabilities.c | 3 +-
> src/conf/domain_conf.c | 21 +++---
> src/util/virresctrl.c | 137 ++--
>
>
On Fri, Apr 03, 2020 at 07:02:17PM +0200, Rafael Fonseca wrote:
> On Fri, Apr 3, 2020 at 5:51 PM Rafael Fonseca wrote:
> >
> > Anyway I'll replace them by g_clear_object. Tks.
>
> Is it ok if I wait to collect more feedback before sending a v2 with
> 's/if (...) g_object_unref/g_clear_object/'?
On Fri, Apr 3, 2020 at 5:51 PM Rafael Fonseca wrote:
>
> Anyway I'll replace them by g_clear_object. Tks.
Is it ok if I wait to collect more feedback before sending a v2 with
's/if (...) g_object_unref/g_clear_object/'?
Att.
--
Rafael Fonseca
On Fri, Apr 3, 2020 at 5:37 PM Peter Krempa wrote:
>
> On Fri, Apr 03, 2020 at 17:15:29 +0200, Rafael Fonseca wrote:
> > Signed-off-by: Rafael Fonseca
> > ---
> > src/conf/capabilities.c | 3 +-
> > src/conf/domain_conf.c | 21 +++---
> > src/util/virresctrl.c | 137
On Fri, Apr 03, 2020 at 17:15:29 +0200, Rafael Fonseca wrote:
> Signed-off-by: Rafael Fonseca
> ---
> src/conf/capabilities.c | 3 +-
> src/conf/domain_conf.c | 21 +++---
> src/util/virresctrl.c | 137 ++--
> src/util/virresctrl.h | 15 +++--
>
Signed-off-by: Rafael Fonseca
---
src/conf/capabilities.c | 3 +-
src/conf/domain_conf.c | 21 +++---
src/util/virresctrl.c | 137 ++--
src/util/virresctrl.h | 15 +++--
tests/virresctrltest.c | 3 +-
5 files changed, 97 insertions(+), 82
