Re: [PATCH 04/10] rpc: don't unref service ref on socket behalf twice

2020-07-21 Thread Daniel P . Berrangé
On Tue, Jul 14, 2020 at 12:32:55PM +0300, Nikolay Shirokovskiy wrote: > Second unref was added in [1]. We don't need it actually as > we pass free callback to virNetSocketAddIOCallback thus > when we call virNetSocketRemoveIOCallback the extra ref for > callback will be dropped without extra

[PATCH 04/10] rpc: don't unref service ref on socket behalf twice

2020-07-14 Thread Nikolay Shirokovskiy
Second unref was added in [1]. We don't need it actually as we pass free callback to virNetSocketAddIOCallback thus when we call virNetSocketRemoveIOCallback the extra ref for callback will be dropped without extra efforts. [1] 355d8f470f9: virNetServerServiceClose: Don't leak sockets ---