Re: [PATCH 04/17] virDomainDeviceAddressParseXML: Switch to virXMLPropEnumDefault()

2022-06-01 Thread Michal Prívozník
On 5/24/22 13:50, Boris Fiuczynski wrote: > On 5/23/22 3:08 PM, Michal Privoznik wrote: >> @@ -6709,21 +6709,13 @@ static int >>   virDomainDeviceAddressParseXML(xmlNodePtr address, >> virDomainDeviceInfo *info) >>   { >> -    g_autofree char *type = virXMLPropStrin

Re: [PATCH 04/17] virDomainDeviceAddressParseXML: Switch to virXMLPropEnumDefault()

2022-05-24 Thread Boris Fiuczynski
On 5/23/22 3:08 PM, Michal Privoznik wrote: @@ -6709,21 +6709,13 @@ static int virDomainDeviceAddressParseXML(xmlNodePtr address, virDomainDeviceInfo *info) { -g_autofree char *type = virXMLPropString(address, "type"); - -if (type) { -if ((info

[PATCH 04/17] virDomainDeviceAddressParseXML: Switch to virXMLPropEnumDefault()

2022-05-23 Thread Michal Privoznik
The virDomainDeviceAddressParseXML() function uses old style of parsing XML (virXMLPropString + str2enum conversion). Use virXMLPropEnumDefault() which encapsulates those steps. Signed-off-by: Michal Privoznik --- src/conf/device_conf.c | 12 - src/conf/device_conf.h | 4 +-- sr

[PATCH 04/17] virDomainDeviceAddressParseXML: Switch to virXMLPropEnumDefault()

2022-04-08 Thread Michal Privoznik
The virDomainDeviceAddressParseXML() function uses old style of parsing XML (virXMLPropString + str2enum conversion). Use virXMLPropEnumDefault() which encapsulates those steps. Signed-off-by: Michal Privoznik --- src/conf/device_conf.c | 12 - src/conf/device_conf.h | 4 +-- sr