Re: [PATCH 08/27] qemu: domain: Add helper for generating 'fdset' ids for VM startup

2022-02-14 Thread Peter Krempa
On Thu, Feb 10, 2022 at 18:53:43 +0100, Ján Tomko wrote: > On a Wednesday in 2022, Peter Krempa wrote: > > When starting a VM we must assign unique IDs for fdsets we add via > > '-add-fd'. For now it was done by using the index of the filedescriptor > > passed to the virCommand. That approach is

Re: [PATCH 08/27] qemu: domain: Add helper for generating 'fdset' ids for VM startup

2022-02-10 Thread Ján Tomko
On a Wednesday in 2022, Peter Krempa wrote: When starting a VM we must assign unique IDs for fdsets we add via '-add-fd'. For now it was done by using the index of the filedescriptor passed to the virCommand. That approach is not very flexible, because you need to have already passed the 'fd' to

Re: [PATCH 08/27] qemu: domain: Add helper for generating 'fdset' ids for VM startup

2022-02-10 Thread Ján Tomko
On a Wednesday in 2022, Peter Krempa wrote: When starting a VM we must assign unique IDs for fdsets we add via '-add-fd'. For now it was done by using the index of the filedescriptor passed to the virCommand. That approach is not very flexible, because you need to have already passed the 'fd' to

[PATCH 08/27] qemu: domain: Add helper for generating 'fdset' ids for VM startup

2022-02-09 Thread Peter Krempa
When starting a VM we must assign unique IDs for fdsets we add via '-add-fd'. For now it was done by using the index of the filedescriptor passed to the virCommand. That approach is not very flexible, because you need to have already passed the 'fd' to virCommand before generating the fdset path,