Re: [PATCH 1/2] iohelper: skip lseek() and ftruncate() on block devices

2021-08-23 Thread Simon Rowe
) and ftruncate() on block devices I'm using 5.4.109. I'll re-submit with changes to the second patch shortly, thanks Simon From: Michal Prívozník Sent: 23 August 2021 16:04 To: Simon Rowe ; libvir-list@redhat.com Subject: Re: [PATCH 1/2] iohelper: s

Re: [PATCH 1/2] iohelper: skip lseek() and ftruncate() on block devices

2021-08-23 Thread Simon Rowe
I'm using 5.4.109. I'll re-submit with changes to the second patch shortly, thanks Simon From: Michal Prívozník Sent: 23 August 2021 16:04 To: Simon Rowe ; libvir-list@redhat.com Subject: Re: [PATCH 1/2] iohelper: skip lseek() and ftruncate() on blo

Re: [PATCH 1/2] iohelper: skip lseek() and ftruncate() on block devices

2021-08-23 Thread Michal Prívozník
On 8/23/21 4:38 PM, Simon Rowe wrote: > O_DIRECT is under control of the caller (though the --bypass-cache option). I > am running in a constrained memory environment and when I don't use O_DIRECT > the dump stalls at 5% load av hits 41 and the system becomes unresponsive. Fair enough. I thought

Re: [PATCH 1/2] iohelper: skip lseek() and ftruncate() on block devices

2021-08-23 Thread Simon Rowe
ozník Sent: 20 August 2021 16:09 To: Simon Rowe ; libvir-list@redhat.com Subject: Re: [PATCH 1/2] iohelper: skip lseek() and ftruncate() on block devices On 8/20/21 10:39 AM, Simon Rowe wrote: > Signed-off-by: Simon Rowe > --- > src/util/iohelper.c | 10 -- > 1 file changed, 8

Re: [PATCH 1/2] iohelper: skip lseek() and ftruncate() on block devices

2021-08-20 Thread Simon Rowe
I can change to doing this if it preferred, Simon From: Michal Prívozník Sent: 20 August 2021 16:09 To: Simon Rowe ; libvir-list@redhat.com Subject: Re: [PATCH 1/2] iohelper: skip lseek() and ftruncate() on block devices On 8/20/21 10:39 AM, Simon Rowe wrote

Re: [PATCH 1/2] iohelper: skip lseek() and ftruncate() on block devices

2021-08-20 Thread Michal Prívozník
On 8/20/21 10:39 AM, Simon Rowe wrote: > Signed-off-by: Simon Rowe > --- > src/util/iohelper.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/src/util/iohelper.c b/src/util/iohelper.c > index b8810d16d3..e6eb178fde 100644 > --- a/src/util/iohelper.c > +++ b/s

[PATCH 1/2] iohelper: skip lseek() and ftruncate() on block devices

2021-08-20 Thread Simon Rowe
Signed-off-by: Simon Rowe --- src/util/iohelper.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/util/iohelper.c b/src/util/iohelper.c index b8810d16d3..e6eb178fde 100644 --- a/src/util/iohelper.c +++ b/src/util/iohelper.c @@ -28,6 +28,8 @@ #include #include