Re: [PATCH 1/2] virdevmapper: Don't error on kernels without DM support

2020-08-18 Thread Michal Privoznik
On 8/18/20 10:10 AM, Pino Toscano wrote: What about stat()ing /dev/mapper/control? That should give you the major/minor of that special character device. That won't help. We need to get the major of devmapper targets. For instance, if there is /dev/dm-0 node, it's going to be a block device

Re: [PATCH 1/2] virdevmapper: Don't error on kernels without DM support

2020-08-18 Thread Peter Krempa
On Tue, Aug 18, 2020 at 09:54:25 +0200, Michal Privoznik wrote: [...] > As promised yesterday, I've dived into the code and found out that the major > number can be specified as a parameter to the dm module (just tested and it > works). So the next thing I tried was to see how could we check whet

Re: [PATCH 1/2] virdevmapper: Don't error on kernels without DM support

2020-08-18 Thread Pino Toscano
On Tuesday, 18 August 2020 09:54:25 CEST Michal Privoznik wrote: > On 8/17/20 5:58 PM, Peter Krempa wrote: > > On Mon, Aug 17, 2020 at 17:40:04 +0200, Michal Privoznik wrote: > >> On 8/17/20 5:16 PM, Peter Krempa wrote: > >>> On Mon, Aug 17, 2020 at 16:26:54 +0200, Michal Privoznik wrote: > In

Re: [PATCH 1/2] virdevmapper: Don't error on kernels without DM support

2020-08-18 Thread Michal Privoznik
On 8/17/20 5:58 PM, Peter Krempa wrote: On Mon, Aug 17, 2020 at 17:40:04 +0200, Michal Privoznik wrote: On 8/17/20 5:16 PM, Peter Krempa wrote: On Mon, Aug 17, 2020 at 16:26:54 +0200, Michal Privoznik wrote: In one of my latest patch (v6.6.0~30) I was trying to remove libdevmapper use in favor

Re: [PATCH 1/2] virdevmapper: Don't error on kernels without DM support

2020-08-17 Thread Peter Krempa
On Mon, Aug 17, 2020 at 17:40:04 +0200, Michal Privoznik wrote: > On 8/17/20 5:16 PM, Peter Krempa wrote: > > On Mon, Aug 17, 2020 at 16:26:54 +0200, Michal Privoznik wrote: > > > In one of my latest patch (v6.6.0~30) I was trying to remove > > > libdevmapper use in favor of our own implementation.

Re: [PATCH 1/2] virdevmapper: Don't error on kernels without DM support

2020-08-17 Thread Michal Privoznik
On 8/17/20 5:16 PM, Peter Krempa wrote: On Mon, Aug 17, 2020 at 16:26:54 +0200, Michal Privoznik wrote: In one of my latest patch (v6.6.0~30) I was trying to remove libdevmapper use in favor of our own implementation. However, the code did not take into account that device mapper can be not comp

Re: [PATCH 1/2] virdevmapper: Don't error on kernels without DM support

2020-08-17 Thread Peter Krempa
On Mon, Aug 17, 2020 at 16:26:54 +0200, Michal Privoznik wrote: > In one of my latest patch (v6.6.0~30) I was trying to remove > libdevmapper use in favor of our own implementation. However, the > code did not take into account that device mapper can be not > compiled into the kernel (e.g. be a sep

[PATCH 1/2] virdevmapper: Don't error on kernels without DM support

2020-08-17 Thread Michal Privoznik
In one of my latest patch (v6.6.0~30) I was trying to remove libdevmapper use in favor of our own implementation. However, the code did not take into account that device mapper can be not compiled into the kernel (e.g. be a separate module that's not loaded) in which case /proc/devices won't have t