Re: [PATCH 1/6] accel: Introduce 'query-accels' QMP command

2021-03-12 Thread Paolo Bonzini
On 12/03/21 10:17, Andrew Jones wrote: On Fri, Mar 12, 2021 at 10:01:43AM +0100, Paolo Bonzini wrote: On 12/03/21 09:48, Andrew Jones wrote: I think we definitely need the additional data section here: For KVM on POWER, it would be good to know whether it's KVM-HV or KVM-PR, for KVM on MIPS it

Re: [PATCH 1/6] accel: Introduce 'query-accels' QMP command

2021-03-12 Thread Andrew Jones
On Fri, Mar 12, 2021 at 10:01:43AM +0100, Paolo Bonzini wrote: > On 12/03/21 09:48, Andrew Jones wrote: > > > I think we definitely need the additional data section here: For KVM on > > > POWER, it would be good to know whether it's KVM-HV or KVM-PR, for KVM on > > > MIPS it would be good to know

Re: [PATCH 1/6] accel: Introduce 'query-accels' QMP command

2021-03-12 Thread Andrew Jones
On Fri, Mar 12, 2021 at 09:52:33AM +0100, Claudio Fontana wrote: > On 3/12/21 9:48 AM, Andrew Jones wrote: > > On Fri, Mar 12, 2021 at 09:11:45AM +0100, Thomas Huth wrote: > >> On 12/03/2021 08.42, Marc-André Lureau wrote: > >>> > >>> > >>> On Fri, Mar 12, 2021 at 3:14 AM Philippe Mathieu-Daudé >

Re: [PATCH 1/6] accel: Introduce 'query-accels' QMP command

2021-03-12 Thread Claudio Fontana
On 3/12/21 9:48 AM, Andrew Jones wrote: > On Fri, Mar 12, 2021 at 09:11:45AM +0100, Thomas Huth wrote: >> On 12/03/2021 08.42, Marc-André Lureau wrote: >>> >>> >>> On Fri, Mar 12, 2021 at 3:14 AM Philippe Mathieu-Daudé >>> mailto:phi...@redhat.com>> wrote: >>> >> [...] >>> +## >>> +#

Re: [PATCH 1/6] accel: Introduce 'query-accels' QMP command

2021-03-12 Thread Paolo Bonzini
On 12/03/21 09:48, Andrew Jones wrote: I think we definitely need the additional data section here: For KVM on POWER, it would be good to know whether it's KVM-HV or KVM-PR, for KVM on MIPS it would be good to know whether it's KVM_VM_MIPS_VZ or KVM_VM_MIPS_TE, for KVM on x86 whether it's the

Re: [PATCH 1/6] accel: Introduce 'query-accels' QMP command

2021-03-12 Thread Andrew Jones
On Fri, Mar 12, 2021 at 09:11:45AM +0100, Thomas Huth wrote: > On 12/03/2021 08.42, Marc-André Lureau wrote: > > > > > > On Fri, Mar 12, 2021 at 3:14 AM Philippe Mathieu-Daudé > > mailto:phi...@redhat.com>> wrote: > > > [...] > > +## > > +# @AcceleratorInfo: > > +# > > +#

Re: [PATCH 1/6] accel: Introduce 'query-accels' QMP command

2021-03-12 Thread Thomas Huth
On 12/03/2021 08.42, Marc-André Lureau wrote: On Fri, Mar 12, 2021 at 3:14 AM Philippe Mathieu-Daudé > wrote: [...] +## +# @AcceleratorInfo: +# +# Accelerator information. +# +# @name: The accelerator name. +# +# Since: 6.0 +##