Re: [PATCH 1/6] qemu: fix domain start with corrupted save file

2020-04-22 Thread Ján Tomko
On a Wednesday in 2020, Peter Krempa wrote: Commit 21ad56e932 introduced a regression where a VM with a corrupted save image file would fail to start on the first attempt. This was caused by returning a wrong return code as 'fd' was abused to also hold double space the return code. Since

Re: [PATCH 1/6] qemu: fix domain start with corrupted save file

2020-04-22 Thread Pavel Mores
On Wed, Apr 22, 2020 at 05:04:54PM +0200, Peter Krempa wrote: > Commit 21ad56e932 introduced a regression where a VM with a corrupted > save image file would fail to start on the first attempt. This was > caused by returning a wrong return code as 'fd' was abused to also hold > the return code. >

[PATCH 1/6] qemu: fix domain start with corrupted save file

2020-04-22 Thread Peter Krempa
Commit 21ad56e932 introduced a regression where a VM with a corrupted save image file would fail to start on the first attempt. This was caused by returning a wrong return code as 'fd' was abused to also hold the return code. Since it's easy to miss this nuance introduce a 'ret' variable for the