Re: [PATCH 15/27] qemuDomainRemoveChrDevice: Detach fdset after chardev hot-unplug

2022-02-10 Thread Ján Tomko
On a Wednesday in 2022, Peter Krempa wrote: Our code uses fdsets for the pipe passed from virtlogd to qemu, but the chardev hot-unplug code neglected to detach the fdset after the chardev was removed. This kept the FDs open by qemu even after they were not used any more. After the refactor to

[PATCH 15/27] qemuDomainRemoveChrDevice: Detach fdset after chardev hot-unplug

2022-02-09 Thread Peter Krempa
Our code uses fdsets for the pipe passed from virtlogd to qemu, but the chardev hot-unplug code neglected to detach the fdset after the chardev was removed. This kept the FDs open by qemu even after they were not used any more. After the refactor to use qemuFDPass for chardevs we now configure