Re: [PATCH 2/2] tests: Turn testQemuPrepareHostBackendChardevOne() into proper mock

2022-04-25 Thread Michal Prívozník
On 4/14/22 18:03, Peter Krempa wrote: > On Thu, Apr 14, 2022 at 16:44:25 +0200, Michal Privoznik wrote: >> Commit v8.0.0-409-gad81aa8ad0 added another function into >> qemuhotplugmock.c. However, it did so in a bit clumsy way: the >> function calls testQemuPrepareHostBackendChardevOne() which is

Re: [PATCH 2/2] tests: Turn testQemuPrepareHostBackendChardevOne() into proper mock

2022-04-14 Thread Peter Krempa
On Thu, Apr 14, 2022 at 16:44:25 +0200, Michal Privoznik wrote: > Commit v8.0.0-409-gad81aa8ad0 added another function into > qemuhotplugmock.c. However, it did so in a bit clumsy way: the > function calls testQemuPrepareHostBackendChardevOne() which is > not exported and is a part of

[PATCH 2/2] tests: Turn testQemuPrepareHostBackendChardevOne() into proper mock

2022-04-14 Thread Michal Privoznik
Commit v8.0.0-409-gad81aa8ad0 added another function into qemuhotplugmock.c. However, it did so in a bit clumsy way: the function calls testQemuPrepareHostBackendChardevOne() which is not exported and is a part of libtest_utils_qemu.a static library. Fortunately, qemuhotplugtest links with it and