Re: [PATCH 2/2] virhook: support hooks placed in several files

2020-06-23 Thread Dmitry Nesterenko
s run all scripts. Dmitry From: Michal Privoznik Sent: Tuesday, June 23, 2020 1:03 PM To: Dmitry Nesterenko; libvir-list@redhat.com Subject: Re: [PATCH 2/2] virhook: support hooks placed in several files On 6/23/20 10:24 AM, Dmitry Nesterenko wrote: > >> virFileI

Re: [PATCH 2/2] virhook: support hooks placed in several files

2020-06-23 Thread Michal Privoznik
On 6/23/20 10:24 AM, Dmitry Nesterenko wrote: virFileIsExecutable() is enough I agree and will fix it in next version of patch. I'm not sure we want this check for output If we are given param for xml output - it is call hook for "migrate" or "restore" and any fail from script can

Re: [PATCH 2/2] virhook: support hooks placed in several files

2020-06-23 Thread Dmitry Nesterenko
tringIsEmpty(*output)) ? *output : (char *)input; From: Michal Privoznik Sent: Monday, June 22, 2020 4:06 PM To: Dmitry Nesterenko; libvir-list@redhat.com Subject: Re: [PATCH 2/2] virhook: support hooks placed in several files On 6/21/20 11:16 PM, Dmitry Nesterenko wrote: > S

Re: [PATCH 2/2] virhook: support hooks placed in several files

2020-06-22 Thread Michal Privoznik
On 6/21/20 11:16 PM, Dmitry Nesterenko wrote: Signed-off-by: Dmitry Nesterenko --- src/util/virhook.c | 110 + 1 file changed, 101 insertions(+), 9 deletions(-) diff --git a/src/util/virhook.c b/src/util/virhook.c index 64ee9a2307..763381d962

[PATCH 2/2] virhook: support hooks placed in several files

2020-06-21 Thread Dmitry Nesterenko
Signed-off-by: Dmitry Nesterenko --- src/util/virhook.c | 110 + 1 file changed, 101 insertions(+), 9 deletions(-) diff --git a/src/util/virhook.c b/src/util/virhook.c index 64ee9a2307..763381d962 100644 --- a/src/util/virhook.c +++