Re: [PATCH 2/4] qemuxml2xmloutdata: Turn tpm-*.xml files into symlinks

2022-01-04 Thread Michal Prívozník
On 1/4/22 09:33, Peter Krempa wrote: > https://www.libvirt.org/hacking.html#preparing-patches > > "If you're going to submit multiple patches, the automated tests must > pass after each patch, not just after the last one." > Alright then. Let me swap those two patches and post v2. Michal

Re: [PATCH 2/4] qemuxml2xmloutdata: Turn tpm-*.xml files into symlinks

2022-01-04 Thread Peter Krempa
On Tue, Jan 04, 2022 at 09:31:39 +0100, Michal Prívozník wrote: > On 1/4/22 09:30, Peter Krempa wrote: > > On Tue, Jan 04, 2022 at 09:14:28 +0100, Michal Privoznik wrote: > >> Make the tpm-*.xml files symlinks to their respective input XMLs > >> from qemuxml2argvdata/ directory. This uncovers a bug

Re: [PATCH 2/4] qemuxml2xmloutdata: Turn tpm-*.xml files into symlinks

2022-01-04 Thread Michal Prívozník
On 1/4/22 09:30, Peter Krempa wrote: > On Tue, Jan 04, 2022 at 09:14:28 +0100, Michal Privoznik wrote: >> Make the tpm-*.xml files symlinks to their respective input XMLs >> from qemuxml2argvdata/ directory. This uncovers a bug in our >> formatter which formats an invalid XML if both >> and elem

Re: [PATCH 2/4] qemuxml2xmloutdata: Turn tpm-*.xml files into symlinks

2022-01-04 Thread Peter Krempa
On Tue, Jan 04, 2022 at 09:14:28 +0100, Michal Privoznik wrote: > Make the tpm-*.xml files symlinks to their respective input XMLs > from qemuxml2argvdata/ directory. This uncovers a bug in our > formatter which formats an invalid XML if both > and elements are present for > . This is going to b

[PATCH 2/4] qemuxml2xmloutdata: Turn tpm-*.xml files into symlinks

2022-01-04 Thread Michal Privoznik
Make the tpm-*.xml files symlinks to their respective input XMLs from qemuxml2argvdata/ directory. This uncovers a bug in our formatter which formats an invalid XML if both and elements are present for . This is going to be addressed in the next commit. Signed-off-by: Michal Privoznik --- ...