Re: [PATCH 2/5] qemu_validate.c: add pSeries NVDIMM size alignment validation

2020-09-10 Thread Daniel Henrique Barboza
On 9/10/20 11:59 AM, Daniel P. Berrangé wrote: On Thu, Jul 30, 2020 at 04:48:01PM -0300, Daniel Henrique Barboza wrote: The existing auto-align behavior for pSeries has the idea to alleviate user configuration of the NVDIMM size, given that the alignment calculation is not trivial to do (256M

Re: [PATCH 2/5] qemu_validate.c: add pSeries NVDIMM size alignment validation

2020-09-10 Thread Daniel P . Berrangé
On Thu, Jul 30, 2020 at 04:48:01PM -0300, Daniel Henrique Barboza wrote: > The existing auto-align behavior for pSeries has the idea to > alleviate user configuration of the NVDIMM size, given that the > alignment calculation is not trivial to do (256MiB alignment > of mem->size - mem->label_size v

Re: [PATCH 2/5] qemu_validate.c: add pSeries NVDIMM size alignment validation

2020-08-24 Thread Daniel Henrique Barboza
On 8/24/20 1:44 PM, Michal Privoznik wrote: On 7/30/20 9:48 PM, Daniel Henrique Barboza wrote: The existing auto-align behavior for pSeries has the idea to alleviate user configuration of the NVDIMM size, given that the alignment calculation is not trivial to do (256MiB alignment of mem->size

Re: [PATCH 2/5] qemu_validate.c: add pSeries NVDIMM size alignment validation

2020-08-24 Thread Michal Privoznik
On 7/30/20 9:48 PM, Daniel Henrique Barboza wrote: The existing auto-align behavior for pSeries has the idea to alleviate user configuration of the NVDIMM size, given that the alignment calculation is not trivial to do (256MiB alignment of mem->size - mem->label_size value, a.k.a guest area). We

[PATCH 2/5] qemu_validate.c: add pSeries NVDIMM size alignment validation

2020-07-30 Thread Daniel Henrique Barboza
The existing auto-align behavior for pSeries has the idea to alleviate user configuration of the NVDIMM size, given that the alignment calculation is not trivial to do (256MiB alignment of mem->size - mem->label_size value, a.k.a guest area). We align mem->size down to avoid end of file problems.