Re: [PATCH 2/9] virstring: Introduce virStringIsNull()

2020-07-03 Thread Daniel P . Berrangé
On Fri, Jul 03, 2020 at 12:28:43PM +0200, Michal Privoznik wrote: > This function will be used to detect zero buffers (which are > going to be interpreted as hole in virStream later). > > I shamelessly took inspiration from coreutils. > > Signed-off-by: Michal Privoznik > --- > src/libvirt_priv

Re: [PATCH 2/9] virstring: Introduce virStringIsNull()

2020-07-03 Thread Daniel P . Berrangé
On Fri, Jul 03, 2020 at 03:13:29PM +0200, Michal Privoznik wrote: > On 7/3/20 2:08 PM, Ján Tomko wrote: > > On a Friday in 2020, Michal Privoznik wrote: > > > This function will be used to detect zero buffers (which are > > > going to be interpreted as hole in virStream later). > > > > > > I shame

Re: [PATCH 2/9] virstring: Introduce virStringIsNull()

2020-07-03 Thread Michal Privoznik
On 7/3/20 2:08 PM, Ján Tomko wrote: On a Friday in 2020, Michal Privoznik wrote: This function will be used to detect zero buffers (which are going to be interpreted as hole in virStream later). I shamelessly took inspiration from coreutils. How is that okay, isn't coreutils GPL-licensed?

Re: [PATCH 2/9] virstring: Introduce virStringIsNull()

2020-07-03 Thread Ján Tomko
On a Friday in 2020, Michal Privoznik wrote: This function will be used to detect zero buffers (which are going to be interpreted as hole in virStream later). I shamelessly took inspiration from coreutils. How is that okay, isn't coreutils GPL-licensed? Jano Signed-off-by: Michal Privoznik

[PATCH 2/9] virstring: Introduce virStringIsNull()

2020-07-03 Thread Michal Privoznik
This function will be used to detect zero buffers (which are going to be interpreted as hole in virStream later). I shamelessly took inspiration from coreutils. Signed-off-by: Michal Privoznik --- src/libvirt_private.syms | 1 + src/util/virstring.c | 40 +++