Re: [PATCH 3/3] qemuSnapshotCreate: Don't insert snapshot into list with VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA

2022-01-12 Thread Peter Krempa
On Tue, Jan 11, 2022 at 15:53:22 +0100, Michal Prívozník wrote: > On 1/11/22 10:53, Peter Krempa wrote: [...] > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2039131 > > Signed-off-by: Peter Krempa > > --- > > src/qemu/qemu_snapshot.c | 25 +++-- > > 1 file

Re: [PATCH 3/3] qemuSnapshotCreate: Don't insert snapshot into list with VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA

2022-01-11 Thread Michal Prívozník
On 1/11/22 10:53, Peter Krempa wrote: > Our approach to snapshots without metadata was to insert them to the > snapshot list and then later remove them from the list when the flag is > present. > > This quirky logic was broken in a recent refactor of the snapshot code > causing that the snapshot

[PATCH 3/3] qemuSnapshotCreate: Don't insert snapshot into list with VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA

2022-01-11 Thread Peter Krempa
Our approach to snapshots without metadata was to insert them to the snapshot list and then later remove them from the list when the flag is present. This quirky logic was broken in a recent refactor of the snapshot code causing that the snapshot stayed inserted in the snapshot list. Recent