Re: [PATCH 3/3] virGlobalInit: Make glib init its own global state

2023-06-22 Thread Daniel P . Berrangé
On Thu, Jun 22, 2023 at 11:10:25AM +0200, Michal Privoznik wrote: > On Wed, Jun 21, 2023 at 5:30 PM Daniel P. Berrangé > wrote: > > > > On Wed, Jun 21, 2023 at 04:09:11PM +0200, Michal Privoznik wrote: > > > This should not be needed, but here's what's happening: > > > virStrToLong_*() family of

Re: [PATCH 3/3] virGlobalInit: Make glib init its own global state

2023-06-22 Thread Michal Privoznik
On Wed, Jun 21, 2023 at 5:30 PM Daniel P. Berrangé wrote: > > On Wed, Jun 21, 2023 at 04:09:11PM +0200, Michal Privoznik wrote: > > This should not be needed, but here's what's happening: > > virStrToLong_*() family of functions was switched from strtol*() > > to g_ascii_strtol*() in order to hand

Re: [PATCH 3/3] virGlobalInit: Make glib init its own global state

2023-06-21 Thread Daniel P . Berrangé
On Wed, Jun 21, 2023 at 04:09:11PM +0200, Michal Privoznik wrote: > This should not be needed, but here's what's happening: > virStrToLong_*() family of functions was switched from strtol*() > to g_ascii_strtol*() in order to handle corner cases on Windows > (most notably parsing hex numbers with b

[PATCH 3/3] virGlobalInit: Make glib init its own global state

2023-06-21 Thread Michal Privoznik
This should not be needed, but here's what's happening: virStrToLong_*() family of functions was switched from strtol*() to g_ascii_strtol*() in order to handle corner cases on Windows (most notably parsing hex numbers with base=0) - see v9.4.0-61-g2ed41d7cd9. But what we did not realize back then,