Re: [PATCH 3/9] build: eliminate useless WITH_VIRTUALPORT check

2020-10-01 Thread Laine Stump
On 10/1/20 11:04 AM, Pavel Hrdina wrote: We should also remove the 'virtualport' option from meson_options.txt . Ah, okay. I hadn't been aware of that file. Fortunately my final sanity builds were delayed while dealing with the daily "school issues", so I haven't pushed yet :-)

Re: [PATCH 3/9] build: eliminate useless WITH_VIRTUALPORT check

2020-10-01 Thread Pavel Hrdina
On Wed, Sep 30, 2020 at 07:14:38PM -0400, Laine Stump wrote: > WITH_VIRTUALPORT just checks that we are building on Linux and that > IFLA_PORT_MAX is defined in linux/if_link.h. Back when 802.11Qb[gh] > support was added, the IFLA_* stuff was new (introduced in kernel > 2.6.35, backported to RHEL6

[PATCH 3/9] build: eliminate useless WITH_VIRTUALPORT check

2020-09-30 Thread Laine Stump
WITH_VIRTUALPORT just checks that we are building on Linux and that IFLA_PORT_MAX is defined in linux/if_link.h. Back when 802.11Qb[gh] support was added, the IFLA_* stuff was new (introduced in kernel 2.6.35, backported to RHEL6 2.6.32 kernel at some point), and so this extra check was necessary,