Re: [PATCH 4/4] bhyve: add VNC password support

2020-05-06 Thread Fabian Freyer
On 6 May 2020, at 15:41, Daniel P. Berrangé wrote: On Linux at least, providing passwords on the command line is considered a security flaw, because any user can see the command line args of any other process on the host. Agreed. The only reason bhyve supports this is to support VNC clients t

Re: [PATCH 4/4] bhyve: add VNC password support

2020-05-06 Thread Daniel P . Berrangé
On Wed, May 06, 2020 at 01:35:55PM +, Fabian Freyer wrote: > Support setting a password for the VNC framebuffer using the passwd > attribute on the element, if the driver has the > BHYVE_CAP_VNC_PASSWORD capability. > > Note that virsh domxml-from-native does not output the password in the >

[PATCH 4/4] bhyve: add VNC password support

2020-05-06 Thread Fabian Freyer
Support setting a password for the VNC framebuffer using the passwd attribute on the element, if the driver has the BHYVE_CAP_VNC_PASSWORD capability. Note that virsh domxml-from-native does not output the password in the generated XML, as VIR_DOMAIN_DEF_FORMAT_SECURE is not set when formatting t