Re: [PATCH 4/4] util: qcow2GetExtensions: Remove support for 'data file' extension

2020-04-27 Thread Peter Krempa
On Fri, Apr 24, 2020 at 10:25:15 -0500, Eric Blake wrote: > On 4/24/20 10:18 AM, Peter Krempa wrote: > > On Fri, Apr 24, 2020 at 09:52:00 -0500, Eric Blake wrote: > > > On 4/24/20 4:24 AM, Peter Krempa wrote: > > > > The implementation was never finished in libvirt. Remove it. > > > > > > > >

Re: [PATCH 4/4] util: qcow2GetExtensions: Remove support for 'data file' extension

2020-04-24 Thread Eric Blake
On 4/24/20 10:18 AM, Peter Krempa wrote: On Fri, Apr 24, 2020 at 09:52:00 -0500, Eric Blake wrote: On 4/24/20 4:24 AM, Peter Krempa wrote: The implementation was never finished in libvirt. Remove it. Signed-off-by: Peter Krempa --- src/util/virstoragefile.c | 19 ++- 1

Re: [PATCH 4/4] util: qcow2GetExtensions: Remove support for 'data file' extension

2020-04-24 Thread Peter Krempa
On Fri, Apr 24, 2020 at 09:52:00 -0500, Eric Blake wrote: > On 4/24/20 4:24 AM, Peter Krempa wrote: > > The implementation was never finished in libvirt. Remove it. > > > > Signed-off-by: Peter Krempa > > --- > > src/util/virstoragefile.c | 19 ++- > > 1 file changed, 2

Re: [PATCH 4/4] util: qcow2GetExtensions: Remove support for 'data file' extension

2020-04-24 Thread Eric Blake
On 4/24/20 4:24 AM, Peter Krempa wrote: The implementation was never finished in libvirt. Remove it. Signed-off-by: Peter Krempa --- src/util/virstoragefile.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) Shouldn't we at least recognize if there is a qcow2

Re: [PATCH 4/4] util: qcow2GetExtensions: Remove support for 'data file' extension

2020-04-24 Thread Ján Tomko
On a Friday in 2020, Peter Krempa wrote: The implementation was never finished in libvirt. Remove it. Signed-off-by: Peter Krempa --- src/util/virstoragefile.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) Reviewed-by: Ján Tomko Jano signature.asc

[PATCH 4/4] util: qcow2GetExtensions: Remove support for 'data file' extension

2020-04-24 Thread Peter Krempa
The implementation was never finished in libvirt. Remove it. Signed-off-by: Peter Krempa --- src/util/virstoragefile.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 32ca481cc0..6dc9d1f016