Re: [PATCH 4/5] virFileRewrite: Allow callback report errors

2022-02-11 Thread Michal Prívozník
On 2/10/22 17:12, Daniel P. Berrangé wrote: > On Thu, Feb 10, 2022 at 12:13:25PM +0100, Michal Privoznik wrote: >> Sometimes it may be handy for the callback to report error, even >> though our current callbacks are trivial. Let's report an error >> only if callback returns a well known value,

Re: [PATCH 4/5] virFileRewrite: Allow callback report errors

2022-02-10 Thread Daniel P . Berrangé
On Thu, Feb 10, 2022 at 12:13:25PM +0100, Michal Privoznik wrote: > Sometimes it may be handy for the callback to report error, even > though our current callbacks are trivial. Let's report an error > only if callback returns a well known value, otherwise assume it > reported error message on its

[PATCH 4/5] virFileRewrite: Allow callback report errors

2022-02-10 Thread Michal Privoznik
Sometimes it may be handy for the callback to report error, even though our current callbacks are trivial. Let's report an error only if callback returns a well known value, otherwise assume it reported error message on its own. Signed-off-by: Michal Privoznik --- src/util/virfile.c | 13