Re: [PATCH 6/8] util: Check for errors in virLogSetFromEnv

2022-01-05 Thread Martin Kletzander
On Wed, Jan 05, 2022 at 12:29:18PM +0100, Erik Skultety wrote: On Tue, Jan 04, 2022 at 02:47:10PM +0100, Martin Kletzander wrote: And make callers check the return value as well. This helps error out early for invalid environment variables. That is desirable because it could lead to deadlocks.

Re: [PATCH 6/8] util: Check for errors in virLogSetFromEnv

2022-01-05 Thread Erik Skultety
On Tue, Jan 04, 2022 at 02:47:10PM +0100, Martin Kletzander wrote: > And make callers check the return value as well. This helps error out early > for > invalid environment variables. > > That is desirable because it could lead to deadlocks. This can happen when > resetting logging after fork()

[PATCH 6/8] util: Check for errors in virLogSetFromEnv

2022-01-04 Thread Martin Kletzander
And make callers check the return value as well. This helps error out early for invalid environment variables. That is desirable because it could lead to deadlocks. This can happen when resetting logging after fork() reports translated errors because gettext functions are not reentrant. Well, i